Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419903003: merge verify_deps into debug_info (Closed)

Created:
5 years, 2 months ago by Harry Terkelsen
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M README.md View 3 chunks +0 lines, -22 lines 0 comments Download
M bin/debug_info.dart View 1 5 chunks +27 lines, -3 lines 0 comments Download
D bin/verify_deps.dart View 1 chunk +0 lines, -49 lines 0 comments Download
M pubspec.yaml View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 2 months ago (2015-10-21 23:02:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1419903003/diff/1/bin/debug_info.dart File bin/debug_info.dart (right): https://codereview.chromium.org/1419903003/diff/1/bin/debug_info.dart#newcode32 bin/debug_info.dart:32: // Validate that codesize of elements adds up ...
5 years, 2 months ago (2015-10-21 23:05:31 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1419903003/diff/1/bin/debug_info.dart File bin/debug_info.dart (right): https://codereview.chromium.org/1419903003/diff/1/bin/debug_info.dart#newcode32 bin/debug_info.dart:32: // Validate that codesize of elements adds up to ...
5 years, 2 months ago (2015-10-21 23:07:44 UTC) #4
Harry Terkelsen
5 years, 2 months ago (2015-10-21 23:08:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6534a196fe8df9751a6b8df2035dd04d41c0abbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698