src/IceFixups.cpp - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceFixups.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceFixups.cpp

diff --git a/src/IceFixups.cpp b/src/IceFixups.cpp

index ddc79796ac72dd483badb56de1bc6148ae207342..305e695659b2f428c0c958c7f98da3089a0d962f 100644

--- a/src/IceFixups.cpp

+++ b/src/IceFixups.cpp

@@ -24,7 +24,7 @@ const Constant *AssemblerFixup::NullSymbol = nullptr;

RelocOffsetT AssemblerFixup::offset() const {

if (isNullSymbol())

return 0;

- if (const auto CR = llvm::dyn_cast<ConstantRelocatable>(value_))

+ if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(value_))

return CR->getOffset();

return 0;

}

@@ -34,7 +34,7 @@ IceString AssemblerFixup::symbol(const GlobalContext *Ctx) const {

llvm::raw_string_ostream Str(Buffer);

const Constant *C = value_;

assert(!isNullSymbol());

- if (const auto CR = llvm::dyn_cast<ConstantRelocatable>(C)) {

+ if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(C)) {

if (CR->getSuppressMangling())

Str << CR->getName();

else

« no previous file with comments | « src/IceELFObjectWriter.cpp ('k') | src/IceGlobalContext.cpp » ('j') | no next file with comments »