src/IceConverter.cpp - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceConverter.cpp

diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp

index a84ae2cf69d4e2004ed508f82305a148c82619e7..89fa2e3618242c8f7c1ee49212efac90c85b4548 100644

--- a/src/IceConverter.cpp

+++ b/src/IceConverter.cpp

@@ -668,8 +668,8 @@ private:

// declaration.

void addGlobalInitializer(Ice::VariableDeclaration &Global,

const Constant *Initializer) {

- const bool HasOffset = false;

- const Ice::RelocOffsetT Offset = 0;

+ constexpr bool HasOffset = false;

+ constexpr Ice::RelocOffsetT Offset = 0;

addGlobalInitializer(Global, Initializer, HasOffset, Offset);

}

« no previous file with comments | « src/IceConditionCodesX8664.h ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »