Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/IceBrowserCompileServer.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceCfg.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceBrowserCompileServer.cpp
diff --git a/src/IceBrowserCompileServer.cpp b/src/IceBrowserCompileServer.cpp
index 4d5705f02b5c3d76d6545c27a3aae7b8c6a06040..94b991ad5469556144f01b2130c0c8eec1071641 100644
--- a/src/IceBrowserCompileServer.cpp
+++ b/src/IceBrowserCompileServer.cpp
@@ -94,8 +94,8 @@ struct nacl_irt_pnacl_compile_funcs SubzeroCallbacks {
std::unique_ptr<llvm::raw_fd_ostream> getOutputStream(int FD) {
if (FD <= 0)
llvm::report_fatal_error("Invalid output FD");
- const bool CloseOnDtor = true;
- const bool Unbuffered = false;
+ constexpr bool CloseOnDtor = true;
+ constexpr bool Unbuffered = false;
return std::unique_ptr<llvm::raw_fd_ostream>(
new llvm::raw_fd_ostream(FD, CloseOnDtor, Unbuffered));
}
« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceCfg.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698