Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: unittest/AssemblerX8664/GPRArith.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Bring back ByteRegister Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: unittest/AssemblerX8664/GPRArith.cpp
diff --git a/unittest/AssemblerX8664/GPRArith.cpp b/unittest/AssemblerX8664/GPRArith.cpp
index ee5c01c971025e58482ccd5a3b2c259c82c439ac..8aba030ef89762eefb9595707a4fb9829afd6cba 100644
--- a/unittest/AssemblerX8664/GPRArith.cpp
+++ b/unittest/AssemblerX8664/GPRArith.cpp
@@ -41,7 +41,7 @@ TEST_F(AssemblerX8664Test, SetCC) {
__ mov(IceType_i32, Encoded_GPR_##Src1(), Immediate(Value1)); \
__ cmp(IceType_i32, Encoded_GPR_##Src0(), Encoded_GPR_##Src1()); \
__ mov(IceType_i32, Encoded_GPR_##Dest(), Immediate(0)); \
- __ setcc(Cond::Br_##C, RegX8664::getEncodedByteReg(Encoded_GPR_##Dest())); \
+ __ setcc(Cond::Br_##C, Encoded_GPR_##Dest()); \
__ setcc(Cond::Br_##C, dwordAddress(T0)); \
\
AssembledTest test = assemble(); \
@@ -1759,7 +1759,7 @@ TEST_F(AssemblerX8664Test, Bt) {
__ mov(IceType_i32, Encoded_GPR_##Dst(), Immediate(Value0)); \
__ mov(IceType_i32, Encoded_GPR_##Src(), Immediate(Value1)); \
__ bt(Encoded_GPR_##Dst(), Encoded_GPR_##Src()); \
- __ setcc(Cond::Br_b, ByteRegister::Encoded_Reg_al); \
+ __ setcc(Cond::Br_b, GPRRegister::Encoded_Reg_al); \
__ And(IceType_i32, Encoded_GPR_eax(), Immediate(0xFFu)); \
\
AssembledTest test = assemble(); \

Powered by Google App Engine
This is Rietveld 408576698