Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: unittest/AssemblerX8632/GPRArith.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Bring back ByteRegister Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: unittest/AssemblerX8632/GPRArith.cpp
diff --git a/unittest/AssemblerX8632/GPRArith.cpp b/unittest/AssemblerX8632/GPRArith.cpp
index 309e345983a11335af157ffba04d609cf3b88431..c5ed29a8b98e95a173618cd51a4e0ddaa0a247e1 100644
--- a/unittest/AssemblerX8632/GPRArith.cpp
+++ b/unittest/AssemblerX8632/GPRArith.cpp
@@ -54,8 +54,7 @@ TEST_F(AssemblerX8632Test, SetCC) {
__ cmp(IceType_i32, GPRRegister::Encoded_Reg_##Src0, \
GPRRegister::Encoded_Reg_##Src1); \
__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Dest, Immediate(0)); \
- __ setcc(Cond::Br_##C, \
- RegX8632::getEncodedByteReg(GPRRegister::Encoded_Reg_##Dest)); \
+ __ setcc(Cond::Br_##C, GPRRegister::Encoded_Reg_##Dest); \
__ setcc(Cond::Br_##C, dwordAddress(T0)); \
\
AssembledTest test = assemble(); \
@@ -1756,7 +1755,7 @@ TEST_F(AssemblerX8632Test, Bt) {
__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Dst, Immediate(Value0)); \
__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Src, Immediate(Value1)); \
__ bt(GPRRegister::Encoded_Reg_##Dst, GPRRegister::Encoded_Reg_##Src); \
- __ setcc(Cond::Br_b, ByteRegister::Encoded_Reg_al); \
+ __ setcc(Cond::Br_b, GPRRegister::Encoded_Reg_al); \
__ And(IceType_i32, GPRRegister::Encoded_Reg_eax, Immediate(0xFFu)); \
\
AssembledTest test = assemble(); \

Powered by Google App Engine
This is Rietveld 408576698