Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceFixups.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add some comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceFixups.cpp
diff --git a/src/IceFixups.cpp b/src/IceFixups.cpp
index 7b2025ec178467a4814bbb204faf2485a5e40774..c0d63f652eebd7073abf9dd0e2a3571cfe75c3a3 100644
--- a/src/IceFixups.cpp
+++ b/src/IceFixups.cpp
@@ -24,7 +24,7 @@ const Constant *AssemblerFixup::NullSymbol = nullptr;
RelocOffsetT AssemblerFixup::offset() const {
if (isNullSymbol())
return 0;
- if (const auto CR = llvm::dyn_cast<ConstantRelocatable>(value_))
+ if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(value_))
return CR->getOffset();
return 0;
}
@@ -34,7 +34,7 @@ IceString AssemblerFixup::symbol(const GlobalContext *Ctx) const {
llvm::raw_string_ostream Str(Buffer);
const Constant *C = value_;
assert(!isNullSymbol());
- if (const auto CR = llvm::dyn_cast<ConstantRelocatable>(C)) {
+ if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(C)) {
if (CR->getSuppressMangling())
Str << CR->getName();
else

Powered by Google App Engine
This is Rietveld 408576698