Subzero: Refactor x86 register definitions to use the alias mechanism.

src/IceGlobalContext.cpp

 //===- subzero/src/IceGlobalContext.cpp - Global context defs -------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 92 matching lines @@
     typename ValueType::PrimType V1 = llvm::cast<ValueType>(Const1)->getValue();
     typename ValueType::PrimType V2 = llvm::cast<ValueType>(Const2)->getValue();
     return V1 < V2;
   }
 };
 template <typename ValueType>
 struct KeyCompareLess<
     ValueType, typename std::enable_if<
                    std::is_same<ValueType, ConstantRelocatable>::value>::type> {
   bool operator()(const Constant *Const1, const Constant *Const2) const {
-    auto V1 = llvm::cast<ValueType>(Const1);
-    auto V2 = llvm::cast<ValueType>(Const2);
+    auto *V1 = llvm::cast<ValueType>(Const1);
+    auto *V2 = llvm::cast<ValueType>(Const2);
     if (V1->getName() == V2->getName())
       return V1->getOffset() < V2->getOffset();
     return V1->getName() < V2->getName();
   }
 };
 
 // TypePool maps constants of type KeyType (e.g. float) to pointers to
 // type ValueType (e.g. ConstantFloat).
 template <Type Ty, typename KeyType, typename ValueType> class TypePool {
   TypePool(const TypePool &) = delete;
@@ skipping 387 matching lines @@
         Asm->alignFunction();
         IceString MangledName = mangleName(Asm->getFunctionName());
         switch (getFlags().getOutFileType()) {
         case FT_Elf:
           getObjectWriter()->writeFunctionCode(MangledName, Asm->getInternal(),
                                                Asm.get());
           break;
         case FT_Iasm: {
           OstreamLocker L(this);
           Cfg::emitTextHeader(MangledName, this, Asm.get());
-          Asm->emitIASBytes();
+          Asm->emitIASBytes(this);
         } break;
         case FT_Asm:
           llvm::report_fatal_error("Unexpected FT_Asm");
           break;
         }
       } break;
       case EmitterWorkItem::WI_Cfg: {
         if (!BuildDefs::dump())
           llvm::report_fatal_error("WI_Cfg work item created inappropriately");
         lowerGlobalsIfNoCodeHasBeenSeen();
@@ skipping 243 matching lines @@
 }
 
 Constant *GlobalContext::getConstantSym(RelocOffsetT Offset,
                                         const IceString &Name,
                                         bool SuppressMangling) {
   return getConstPool()->Relocatables.getOrAdd(
       this, RelocatableTuple(Offset, Name, SuppressMangling));
 }
 
 Constant *GlobalContext::getConstantExternSym(const IceString &Name) {
-  const RelocOffsetT Offset = 0;
-  const bool SuppressMangling = true;
+  constexpr RelocOffsetT Offset = 0;
+  constexpr bool SuppressMangling = true;
   return getConstPool()->ExternRelocatables.getOrAdd(
       this, RelocatableTuple(Offset, Name, SuppressMangling));
 }
 
 Constant *GlobalContext::getConstantUndef(Type Ty) {
   return getConstPool()->Undefs.getOrAdd(this, Ty);
 }
 
 // All locking is done by the getConstant*() target function.
 Constant *GlobalContext::getConstantZero(Type Ty) {
@@ skipping 207 matching lines @@
   Ctx = Func->getContext();
   Active =
       Func->getFocusedTiming() || Ctx->getFlags().getSubzeroTimingEnabled();
   if (Active)
     Ctx->pushTimer(ID, StackID);
 }
 
 ICE_TLS_DEFINE_FIELD(GlobalContext::ThreadContext *, GlobalContext, TLS);
 
 } // end of namespace Ice