Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 14199003: Turn off pre-tenuring of fast literals when we turn off high promotion mode. (Closed)

Created:
7 years, 8 months ago by Hannes Payer (out of office)
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Turn off pre-tenuring of fast literals when we turn off high promotion mode. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14251

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/heap.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 8 months ago (2013-04-12 10:41:38 UTC) #1
danno
lgtm
7 years, 8 months ago (2013-04-12 10:49:48 UTC) #2
Michael Starzinger
LGTM with a nit. https://codereview.chromium.org/14199003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/14199003/diff/1/src/heap.cc#newcode973 src/heap.cc:973: // We turn off pre-tenuring ...
7 years, 8 months ago (2013-04-12 10:53:41 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/14199003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/14199003/diff/1/src/heap.cc#newcode973 src/heap.cc:973: // We turn off pre-tenuring when we turn off ...
7 years, 8 months ago (2013-04-12 11:02:38 UTC) #4
Hannes Payer (out of office)
7 years, 8 months ago (2013-04-12 11:14:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698