Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: cc/resources/video_resource_updater.h

Issue 14199002: Send hardware video frames with mailboxes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: video-mailbox: remove extra produce in webmediaplayer_impl Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/video_resource_updater.h
diff --git a/cc/resources/video_resource_updater.h b/cc/resources/video_resource_updater.h
index 8e073901725fd250f0fee6391a463f4622baa79c..a7449ec0882ff490682dfa58037a788862935ca8 100644
--- a/cc/resources/video_resource_updater.h
+++ b/cc/resources/video_resource_updater.h
@@ -47,10 +47,6 @@ class VideoFrameExternalResources {
ResourceType type;
std::vector<TextureMailbox> mailboxes;
- // TODO(danakj): Remove these when we get a Mailbox from VideoFrame.
- unsigned hardware_resource;
- TextureMailbox::ReleaseCallback hardware_release_callback;
-
// TODO(danakj): Remove these too.
std::vector<unsigned> software_resources;
TextureMailbox::ReleaseCallback software_release_callback;
@@ -67,10 +63,7 @@ class VideoResourceUpdater
explicit VideoResourceUpdater(ResourceProvider* resource_provider);
~VideoResourceUpdater();
- VideoFrameExternalResources CreateForHardwarePlanes(
- const scoped_refptr<media::VideoFrame>& video_frame);
-
- VideoFrameExternalResources CreateForSoftwarePlanes(
+ VideoFrameExternalResources CreateExternalResourcesFromVideoFrame(
const scoped_refptr<media::VideoFrame>& video_frame);
private:
@@ -92,6 +85,10 @@ class VideoResourceUpdater
void DeleteResource(unsigned resource_id);
bool VerifyFrame(const scoped_refptr<media::VideoFrame>& video_frame);
+ VideoFrameExternalResources CreateForHardwarePlanes(
+ const scoped_refptr<media::VideoFrame>& video_frame);
+ VideoFrameExternalResources CreateForSoftwarePlanes(
+ const scoped_refptr<media::VideoFrame>& video_frame);
struct RecycleResourceData {
unsigned resource_id;
@@ -103,10 +100,6 @@ class VideoResourceUpdater
RecycleResourceData data,
unsigned sync_point,
bool lost_resource);
- static void ReturnTexture(base::WeakPtr<VideoResourceUpdater> updater,
- unsigned resource_id,
- unsigned sync_point,
- bool lost_resource);
ResourceProvider* resource_provider_;
scoped_ptr<media::SkCanvasVideoRenderer> video_renderer_;

Powered by Google App Engine
This is Rietveld 408576698