Send hardware video frames with mailboxes.

webkit/media/webmediaplayer_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 723 matching lines @@
     bool premultiply_alpha,
     bool flip_y) {
   scoped_refptr<media::VideoFrame> video_frame;
   {
     base::AutoLock auto_lock(lock_);
     video_frame = current_frame_;
   }
   if (video_frame &&
       video_frame->format() == media::VideoFrame::NATIVE_TEXTURE &&
       video_frame->texture_target() == GL_TEXTURE_2D) {
+#ifndef VIDEO_FRAME_MAILBOX
     uint32 source_texture = video_frame->texture_id();
+#else
+    uint32 source_texture = web_graphics_context->createTexture();
+
+    web_graphics_context->waitSyncPoint(
+        video_frame->texture_mailbox_sync_point());
+    web_graphics_context->bindTexture(GL_TEXTURE_2D, source_texture);
+    web_graphics_context->consumeTextureCHROMIUM(
+        GL_TEXTURE_2D, video_frame->texture_mailbox().name);
+#endif
+
     // The video is stored in a unmultiplied format, so premultiply
     // if necessary.
     web_graphics_context->pixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM,
         premultiply_alpha);
     // Application itself needs to take care of setting the right flip_y
     // value down to get the expected result.
     // flip_y==true means to reverse the video orientation while
     // flip_y==false means to keep the intrinsic orientation.
     web_graphics_context->pixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, flip_y);
     web_graphics_context->copyTextureCHROMIUM(GL_TEXTURE_2D,
         source_texture, texture, level, internal_format);
     web_graphics_context->pixelStorei(GL_UNPACK_FLIP_Y_CHROMIUM, false);
     web_graphics_context->pixelStorei(GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM,
         false);
+
+#ifdef VIDEO_FRAME_MAILBOX

[scherkus (not reviewing), 2013/04/17 20:09:34]

nit: doesn't chromium prefer #if defined(FOO) / #if !defined(FOO)?

[danakj, 2013/04/17 20:12:37]

Does it? The google style guide and chromium style guide both make offhand
references to "#ifdef" which seems to say it's acceptable (this is pretty
transient anyways).

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=64-bit...

[scherkus (not reviewing), 2013/04/17 20:16:58]

yeah I don't really care enough to have it changed

I was basing this off of the OS_XXX defines, which seem to be heavily in favour
of defined():

$ git grep "#ifdef.*OS_WIN" -- "*.h" "*.cc" | wc -l
3

$ git grep "#if defined(OS_WIN)" -- "*.h" "*.cc" | wc -l
2761

+    web_graphics_context->bindTexture(GL_TEXTURE_2D, source_texture);
+    web_graphics_context->produceTextureCHROMIUM(
+        GL_TEXTURE_2D, video_frame->texture_mailbox().name);
+    web_graphics_context->deleteTexture(source_texture);
+#endif
+
     // The flush() operation is not necessary here. It is kept since the
     // performance will be better when it is added than not.
     web_graphics_context->flush();
     return true;
   }
   return false;
 }
 
 // Helper functions to report media EME related stats to UMA. They follow the
 // convention of more commonly used macros UMA_HISTOGRAM_ENUMERATION and
@@ skipping 501 matching lines @@
 
   if (pending_repaint_)
     return;
 
   pending_repaint_ = true;
   main_loop_->PostTask(FROM_HERE, base::Bind(
       &WebMediaPlayerImpl::Repaint, AsWeakPtr()));
 }
 
 }  // namespace webkit_media