Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1419843007: remove_bundled_libraries.py: preserve .gn and .gni files (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/linux/unbundle/remove_bundled_libraries.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-06 10:27:25 UTC) #2
tandrii(chromium)
lgtm, but it's really close to rs-lgtm
5 years, 1 month ago (2015-11-06 13:13:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/434a92f92ccd6393cafd90b6547a9ece2582b0d3 Cr-Commit-Position: refs/heads/master@{#358320}
5 years, 1 month ago (2015-11-06 14:37:19 UTC) #4
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-06 14:37:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
434a92f92ccd6393cafd90b6547a9ece2582b0d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698