ui/android/java/src/org/chromium/ui/resources/ResourceManager.java - Issue 1419843002: Hold a reference to any kind of context in WindowAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

Issue 1419843002: Hold a reference to any kind of context in WindowAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass Context instead of WindowAndroid from native ResourceManager to java side. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/android/java/src/org/chromium/ui/base/WindowAndroid.java ('k') | ui/android/resources/resource_manager_impl.h » ('j') | ui/android/resources/resource_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

diff --git a/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java b/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

index d58bddacddde6f35bddbf11b20a3bcb6470034b3..3695ec80ce4ecf8428c3473f937ca1c68c60ed48 100644

--- a/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

+++ b/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

@@ -50,7 +50,7 @@ public class ResourceManager implements ResourceLoaderCallback {

}

/**

- * Creates an instance of a {@link ResourceManager}. This will

+ * Creates an instance of a {@link ResourceManager}.

* @param context A {@link Context} instance to grab {@link Resources} from.

* @param staticResourceManagerPtr A pointer to the native component of this class.

* @return A new instance of a {@link ResourceManager}.