android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1419843002: Hold a reference to any kind of context in WindowAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1419843002: Hold a reference to any kind of context in WindowAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move weak context/activity ref from ActivityWA to WA (WindowAndroid) and remove Context ref in Reso… Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/compositor_impl_android.cc » ('j') | ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 644076bc9977db203ebaa500e39095e265f64354..86b0f272ddddf7d535b41eaece7d350bda9a27ae 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -911,8 +911,7 @@ public class AwContents implements SmartClipProvider,

Activity activity = ContentViewCore.activityFromContext(context);

if (activity == null) {

if (sCachedWindowAndroid == null) {

- sCachedWindowAndroid = new WindowAndroidWrapper(

- new WindowAndroid(context.getApplicationContext()));

+ sCachedWindowAndroid = new WindowAndroidWrapper(new WindowAndroid(context));

}

return sCachedWindowAndroid;

}