Hold a reference to any kind of context in WindowAndroid.

content/browser/renderer_host/compositor_impl_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/compositor_impl_android.h"
 
 #include <android/bitmap.h>
 #include <android/native_window_jni.h>
 
 #include "base/android/jni_android.h"
@@ skipping 214 matching lines @@
       new cc::SurfaceIdAllocator(++g_surface_id_namespace));
   cc::SurfaceManager* manager = GetSurfaceManager();
   DCHECK(manager);
   allocator->RegisterSurfaceIdNamespace(manager);
   return allocator.Pass();
 }
 
 CompositorImpl::CompositorImpl(CompositorClient* client,
                                gfx::NativeWindow root_window)
     : root_layer_(cc::Layer::Create(Compositor::LayerSettings())),
+      resource_manager_(root_window->GetJavaDisplayContext().obj()),

[boliu, 2015/10/21 16:55:38]

So continuing the previous conversation, can resource_manager_ just take
root_window instead

[gsennton, 2015/10/21 17:09:08]

I don't see how that would help (but I might be missing something). We would
either have to call GetJavaDisplayContext() from resource_manager.cc, or call
WindowAndroid.getDisplayContext() from ResourceManager.java. And we want neither
of those to be public if I understand correctly.

[boliu, 2015/10/21 17:13:34]

Conceptually, window_android.cc and resource_manager.cc are in the same layer
(think same package in java). Exposing the GetJavaDisplayContext means exposing
it to the content layer too, which isn't strictly needed.

For c++, "package visible" probably maps to private + friend though, which is
not quite the same thing. But I was wondering if you can actually do this on the
java side and actually make use of java package visible.

[gsennton, 2015/10/22 10:33:36]

../../ui/android/java/src/org/chromium/ui/resources/ResourceManager.java:61:
error: getDisplayContext() is not public in WindowAndroid; cannot be accessed
from outside package
        Context context = windowAndroid.getDisplayContext();

:/
ResourceManager lives in package org.chromium.ui.resources while WindowAndroid
lives in org.chromium.ui.base.

[boliu, 2015/10/22 14:12:59]

Jared, any thoughts here? A bit weird these WindowAndroid and ResourceManager
are not in the same package?

Anyway, even if it's public, only accessed by ui things, it's still better than
this patch.

       surface_id_allocator_(GetSurfaceManager() ? CreateSurfaceIdAllocator()
                                                 : nullptr),
       has_transparent_background_(false),
       device_scale_factor_(1),
       window_(NULL),
       surface_id_(0),
       client_(client),
       root_window_(root_window),
       did_post_swapbuffers_(false),
       ignore_schedule_composite_(false),
@@ skipping 554 matching lines @@
 
 void CompositorImpl::SetNeedsAnimate() {
   needs_animate_ = true;
   if (!host_->visible())
     return;
 
   host_->SetNeedsAnimate();
 }
 
 }  // namespace content