chrome/browser/extensions/install_tracker.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_tracker.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/sync/test/integration/sync_app_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/install_tracker.cc

diff --git a/chrome/browser/extensions/install_tracker.cc b/chrome/browser/extensions/install_tracker.cc

index 67e0cbb943fd480580f467b11a90d41131f340b5..16d091411502d01c7032821cfd9027870806e6fb 100644

--- a/chrome/browser/extensions/install_tracker.cc

+++ b/chrome/browser/extensions/install_tracker.cc

@@ -10,6 +10,7 @@

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/extension_system.h"

#include "extensions/browser/pref_names.h"

namespace extensions {

@@ -24,7 +25,7 @@ InstallTracker::InstallTracker(content::BrowserContext* browser_context,

// Prefs may be null in tests.

if (prefs) {

- AppSorting* sorting = prefs->app_sorting();

+ AppSorting* sorting = ExtensionSystem::Get(browser_context)->app_sorting();

registrar_.Add(this,

chrome::NOTIFICATION_APP_LAUNCHER_REORDERED,

content::Source<AppSorting>(sorting));

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/sync/test/integration/sync_app_helper.cc » ('j') | no next file with comments »