chrome/browser/extensions/extension_service_sync_unittest.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_sync_unittest.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service_sync_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc

index c399a69db27a250473ebb2418a5af24847455a21..3bd4e75453f8c81da8fe921ca397d9c0c27d2155 100644

--- a/chrome/browser/extensions/extension_service_sync_unittest.cc

+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc

@@ -571,7 +571,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncAppDataUserSettings) {

EXPECT_TRUE(initial_ordinal.Equals(app_sync_data->page_ordinal()));

}

- AppSorting* sorting = ExtensionPrefs::Get(profile())->app_sorting();

+ AppSorting* sorting = ExtensionSystem::Get(profile())->app_sorting();

sorting->SetAppLaunchOrdinal(app->id(), initial_ordinal.CreateAfter());

{

syncer::SyncDataList list =

@@ -623,7 +623,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncAppDataUserSettingsOnExtensionMoved) {

new syncer::FakeSyncChangeProcessor),

scoped_ptr<syncer::SyncErrorFactory>(new syncer::SyncErrorFactoryMock()));

- ExtensionPrefs::Get(service()->GetBrowserContext())

+ ExtensionSystem::Get(service()->GetBrowserContext())

->app_sorting()

->OnExtensionMoved(apps[0]->id(), apps[1]->id(), apps[2]->id());

{

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »