chrome/browser/extensions/extension_install_ui_browsertest.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_browsertest.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_install_ui_browsertest.cc

diff --git a/chrome/browser/extensions/extension_install_ui_browsertest.cc b/chrome/browser/extensions/extension_install_ui_browsertest.cc

index 21e0479b4fddcdc87407416dc85f933d884e1039..57feb15fc02f44084cd5997cb726331f9112ac4b 100644

--- a/chrome/browser/extensions/extension_install_ui_browsertest.cc

+++ b/chrome/browser/extensions/extension_install_ui_browsertest.cc

@@ -26,7 +26,6 @@

#include "content/public/browser/web_contents.h"

#include "content/public/test/browser_test_utils.h"

#include "extensions/browser/app_sorting.h"

-#include "extensions/browser/extension_prefs.h"

#include "extensions/common/constants.h"

using content::WebContents;

@@ -234,7 +233,7 @@ IN_PROC_BROWSER_TEST_F(NewTabUISortingBrowserTest,

service->GetInstalledExtension(extensions::kWebStoreAppId);

EXPECT_TRUE(webstore_extension);

AppSorting* sorting =

- extensions::ExtensionPrefs::Get(browser()->profile())->app_sorting();

+ extensions::ExtensionSystem::Get(browser()->profile())->app_sorting();

// Register for notifications in the same way as AppLauncherHandler.

registrar_.Add(this,

« no previous file with comments | « chrome/browser/apps/ephemeral_app_browsertest.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »