chrome/browser/sync/test/integration/sync_app_list_helper.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sync_app_list_helper.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/sync_app_helper.cc ('k') | chrome/browser/sync/test/integration/two_client_apps_sync_test.cc » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sync_app_list_helper.cc

diff --git a/chrome/browser/sync/test/integration/sync_app_list_helper.cc b/chrome/browser/sync/test/integration/sync_app_list_helper.cc

index 94e7b5997b5ecd6e900d53b008a8c703a3a61576..72c984b8809d5b44545bee8d1f37300909dbbe36 100644

--- a/chrome/browser/sync/test/integration/sync_app_list_helper.cc

+++ b/chrome/browser/sync/test/integration/sync_app_list_helper.cc

@@ -12,7 +12,6 @@

#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"

#include "chrome/common/extensions/sync_helper.h"

#include "extensions/browser/app_sorting.h"

-#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_system.h"

#include "ui/app_list/app_list_folder_item.h"

#include "ui/app_list/app_list_item.h"

@@ -173,7 +172,7 @@ void SyncAppListHelper::PrintItem(Profile* profile,

AppListItem* item,

const std::string& label) {

extensions::AppSorting* s =

- extensions::ExtensionPrefs::Get(profile)->app_sorting();

+ extensions::ExtensionSystem::Get(profile)->app_sorting();

std::string id = item->id();

if (item->GetItemType() == AppListFolderItem::kItemType) {

DVLOG(1) << label << item->ToDebugString();