chrome/browser/extensions/extension_service_sync_unittest.cc - Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_sync_unittest.cc

Issue 1419823011: app_sorting() calls should go via ExtensionSystem intsead of prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_sync_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc

index cbf5c1e802bdd8e6cd7326a9f02b5553857bcb6d..af5fc9bcd882a52133466c3cdd7d3436a31d7fde 100644

--- a/chrome/browser/extensions/extension_service_sync_unittest.cc

+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc

@@ -497,7 +497,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncAppDataUserSettings) {

EXPECT_TRUE(initial_ordinal.Equals(app_sync_data->page_ordinal()));

}

- AppSorting* sorting = ExtensionPrefs::Get(profile())->app_sorting();

+ AppSorting* sorting = ExtensionSystem::Get(profile())->app_sorting();

sorting->SetAppLaunchOrdinal(app->id(), initial_ordinal.CreateAfter());

{

syncer::SyncDataList list =

@@ -549,7 +549,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncAppDataUserSettingsOnExtensionMoved) {

new syncer::FakeSyncChangeProcessor),

scoped_ptr<syncer::SyncErrorFactory>(new syncer::SyncErrorFactoryMock()));

- ExtensionPrefs::Get(service()->GetBrowserContext())

+ ExtensionSystem::Get(service()->GetBrowserContext())

->app_sorting()

->OnExtensionMoved(apps[0]->id(), apps[1]->id(), apps[2]->id());

{