app_sorting() calls should go via ExtensionSystem intsead of prefs.

extensions/browser/extension_prefs.h

Index: extensions/browser/extension_prefs.h
diff --git a/extensions/browser/extension_prefs.h b/extensions/browser/extension_prefs.h
index 2e9e84035c11d6c7e5af4238005698d4ef944688..9ba3ef10d6540e6279a562721177abf6f15279aa 100644
--- a/extensions/browser/extension_prefs.h
+++ b/extensions/browser/extension_prefs.h
@@ -511,11 +511,6 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
   // The underlying PrefService.
   PrefService* pref_service() const { return prefs_; }
 
-  // The underlying AppSorting.
-  // TODO(treib,kalman): This should be private, and all callers should go
-  // through the ExtensionSystem instead.
-  AppSorting* app_sorting() const;
-
   // Schedules garbage collection of an extension's on-disk data on the next
   // start of this ExtensionService. Applies only to extensions with isolated
   // storage.
@@ -684,6 +679,9 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
       const syncer::StringOrdinal& suggested_page_ordinal,
       base::DictionaryValue* extension_dict);
 
+  // The underlying AppSorting.
+  AppSorting* app_sorting() const;

[benwells, 2015/11/06 01:04:38]

Nit: should the .cc be reordered to match?

[Deepak, 2015/11/06 06:13:48]

Done.

+
   content::BrowserContext* browser_context_;
 
   // The pref service specific to this set of extension prefs. Owned by the