app_sorting() calls should go via ExtensionSystem intsead of prefs.

chrome/browser/sync/test/integration/sync_app_list_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_app_list_helper.h"
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
 #include "chrome/common/extensions/sync_helper.h"
 #include "extensions/browser/app_sorting.h"
 #include "extensions/browser/extension_prefs.h"

[benwells, 2015/11/06 01:04:37]

nit: Is this include still needed?

[Deepak, 2015/11/06 06:13:47]

Done.

 #include "extensions/browser/extension_system.h"
 #include "ui/app_list/app_list_folder_item.h"
 #include "ui/app_list/app_list_item.h"
 #include "ui/app_list/app_list_model.h"
 
 using app_list::AppListFolderItem;
 using app_list::AppListItem;
 using app_list::AppListItemList;
 using app_list::AppListSyncableService;
 using app_list::AppListSyncableServiceFactory;
@@ skipping 140 matching lines @@
     AppListItem* item = service->GetModel()->top_level_item_list()->item_at(i);
     std::string label = base::StringPrintf("Item(%d): ", static_cast<int>(i));
     PrintItem(profile, item, label);
   }
 }
 
 void SyncAppListHelper::PrintItem(Profile* profile,
                                   AppListItem* item,
                                   const std::string& label) {
   extensions::AppSorting* s =
-      extensions::ExtensionPrefs::Get(profile)->app_sorting();
+      extensions::ExtensionSystem::Get(profile)->app_sorting();
   std::string id = item->id();
   if (item->GetItemType() == AppListFolderItem::kItemType) {
     DVLOG(1) << label << item->ToDebugString();
     AppListFolderItem* folder = static_cast<AppListFolderItem*>(item);
     for (size_t i = 0; i < folder->item_list()->item_count(); ++i) {
       AppListItem* child = folder->item_list()->item_at(i);
       std::string child_label =
           base::StringPrintf(" Folder Item(%d): ", static_cast<int>(i));
       PrintItem(profile, child, child_label);
     }
     return;
   }
   DVLOG(1) << label << item->ToDebugString()
            << " Page: " << s->GetPageOrdinal(id).ToDebugString().substr(0, 8)
            << " Item: "
            << s->GetAppLaunchOrdinal(id).ToDebugString().substr(0, 8);
 }