Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1419823009: Revert of Ignore test failure for mjsunit/for-in-opt in gc stress. (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
Yang, Michael Hablich
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ignore test failure for mjsunit/for-in-opt in gc stress. (patchset #1 id:1 of https://codereview.chromium.org/1295513004/ ) Reason for revert: This test should work. Original issue's description: > Ignore test failure for mjsunit/for-in-opt in gc stress. > > TBR=hablich@chromium.org > BUG=v8:4381 > > Committed: https://crrev.com/22cf0b591968b7b305094d386d6b10e6c0e723cc > Cr-Commit-Position: refs/heads/master@{#30245} TBR=hablich@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4381 LOG=n Committed: https://crrev.com/34143f09d2590d543f6382dbcbaecec3dbaae9f8 Cr-Commit-Position: refs/heads/master@{#31559}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Toon Verwaest
Created Revert of Ignore test failure for mjsunit/for-in-opt in gc stress.
5 years, 1 month ago (2015-10-26 12:08:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419823009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419823009/1
5 years, 1 month ago (2015-10-26 12:08:48 UTC) #2
commit-bot: I haz the power
Failed to apply patch for test/mjsunit/mjsunit.status: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-10-26 12:08:53 UTC) #4
Yang
On 2015/10/26 12:08:53, commit-bot: I haz the power wrote: > Failed to apply patch for ...
5 years, 1 month ago (2015-10-26 12:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419823009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419823009/40001
5 years, 1 month ago (2015-10-26 12:15:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-10-26 12:15:38 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 12:15:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34143f09d2590d543f6382dbcbaecec3dbaae9f8
Cr-Commit-Position: refs/heads/master@{#31559}

Powered by Google App Engine
This is Rietveld 408576698