Chromium Code Reviews

Issue 1419823008: Fix Object.preventExtensions, .seal, .freeze on typed arrays (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
jochen (gone - plz use gerrit), neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Object.preventExtensions, .seal, .freeze on typed arrays BUG=v8:4460 LOG=n Committed: https://crrev.com/b694266bb1573d0dd050cf27e350cb5dd606d664 Cr-Commit-Position: refs/heads/master@{#31556}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+55 lines, -56 lines)
M src/messages.h View 1 chunk +2 lines, -2 lines 0 comments
M src/objects.cc View 6 chunks +30 lines, -23 lines 0 comments
M test/mjsunit/compiler/regress-447567.js View 1 chunk +3 lines, -3 lines 0 comments
M test/mjsunit/messages.js View 1 chunk +3 lines, -3 lines 0 comments
M test/mjsunit/regress/regress-95920.js View 1 chunk +17 lines, -25 lines 0 comments

Messages

Total messages: 7 (2 generated)
Toon Verwaest
jochen@: please review neis@: fyi
5 years, 1 month ago (2015-10-26 10:22:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-26 10:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419823008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419823008/1
5 years, 1 month ago (2015-10-26 10:44:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 11:07:52 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 11:08:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b694266bb1573d0dd050cf27e350cb5dd606d664
Cr-Commit-Position: refs/heads/master@{#31556}

Powered by Google App Engine