test/unittests/compiler/js-type-feedback-unittest.cc - Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/js-type-feedback-unittest.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts

Patch Set: Addressing comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/js-type-feedback-unittest.cc

diff --git a/test/unittests/compiler/js-type-feedback-unittest.cc b/test/unittests/compiler/js-type-feedback-unittest.cc

index a2d51d28443c3113f1ef3364115a9980cec627ce..dece25def1367409e3cf257121aafca366fec4f8 100644

--- a/test/unittests/compiler/js-type-feedback-unittest.cc

+++ b/test/unittests/compiler/js-type-feedback-unittest.cc

@@ -81,15 +81,13 @@ class JSTypeFeedbackTest : public TypedGraphTest {

const char* string, Node* effect, Node* control,

JSTypeFeedbackSpecializer::DeoptimizationMode mode) {

VectorSlotPair feedback;

- Node* global = UndefinedConstant();

Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Handle<Name> name = isolate()->factory()->InternalizeUtf8String(string);

const Operator* op = javascript()->LoadGlobal(name, feedback);

- Node* load =

- graph()->NewNode(op, context, global, vector, context,

- EmptyFrameState(), EmptyFrameState(), effect, control);

+ Node* load = graph()->NewNode(op, vector, context, EmptyFrameState(),

+ EmptyFrameState(), effect, control);

Node* if_success = graph()->NewNode(common()->IfSuccess(), load);

return graph()->NewNode(common()->Return(), load, load, if_success);

}