Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: src/interpreter/interpreter.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecodes.h ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index 503594e4fc2730ebfa46e3d7fd569ce4ee2a4aba..4226158bd8753b3c3e2c18fd64a6e242c7615114 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -184,44 +184,6 @@ void Interpreter::DoStar(compiler::InterpreterAssembler* assembler) {
}
-// LdaGlobal <slot_index>
-//
-// Load the global at |slot_index| into the accumulator.
-void Interpreter::DoLdaGlobal(compiler::InterpreterAssembler* assembler) {
- Node* slot_index = __ BytecodeOperandIdx8(0);
- Node* smi_slot_index = __ SmiTag(slot_index);
- Node* result = __ CallRuntime(Runtime::kLoadGlobalViaContext, smi_slot_index);
- __ SetAccumulator(result);
- __ Dispatch();
-}
-
-
-// StaGlobalSloppy <slot_index>
-//
-// Store the global at |slot_index| with the value in the the accumulator in
-// sloppy mode.
-void Interpreter::DoStaGlobalSloppy(compiler::InterpreterAssembler* assembler) {
- Node* slot_index = __ BytecodeOperandIdx8(0);
- Node* smi_slot_index = __ SmiTag(slot_index);
- Node* value = __ GetAccumulator();
- __ CallRuntime(Runtime::kStoreGlobalViaContext_Sloppy, smi_slot_index, value);
- __ Dispatch();
-}
-
-
-// StaGlobalStrict <slot_index>
-//
-// Store the global at |slot_index| with the value in the the accumulator in
-// strict mode.
-void Interpreter::DoStaGlobalStrict(compiler::InterpreterAssembler* assembler) {
- Node* slot_index = __ BytecodeOperandIdx8(0);
- Node* smi_slot_index = __ SmiTag(slot_index);
- Node* value = __ GetAccumulator();
- __ CallRuntime(Runtime::kStoreGlobalViaContext_Strict, smi_slot_index, value);
- __ Dispatch();
-}
-
-
// LdaContextSlot <context> <slot_index>
//
// Load the object in |slot_index| of |context| into the accumulator.
« no previous file with comments | « src/interpreter/bytecodes.h ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698