Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index 1e7f824a4a97e349a98fb8e43f5877456f66ba0f..c9ea2a68302af0c2d5211659f895eef833ad7699 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -264,30 +264,6 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::StoreAccumulatorInRegister(
}
-BytecodeArrayBuilder& BytecodeArrayBuilder::LoadGlobal(int slot_index) {
- DCHECK(slot_index >= 0);
- if (FitsInIdx8Operand(slot_index)) {
- Output(Bytecode::kLdaGlobal, static_cast<uint8_t>(slot_index));
- } else {
- UNIMPLEMENTED();
- }
- return *this;
-}
-
-
-BytecodeArrayBuilder& BytecodeArrayBuilder::StoreGlobal(
- int slot_index, LanguageMode language_mode) {
- DCHECK(slot_index >= 0);
- Bytecode bytecode = BytecodeForStoreGlobal(language_mode);
- if (FitsInIdx8Operand(slot_index)) {
- Output(bytecode, static_cast<uint8_t>(slot_index));
- } else {
- UNIMPLEMENTED();
- }
- return *this;
-}
-
-
BytecodeArrayBuilder& BytecodeArrayBuilder::LoadContextSlot(Register context,
int slot_index) {
DCHECK(slot_index >= 0);
@@ -919,23 +895,6 @@ Bytecode BytecodeArrayBuilder::BytecodeForKeyedStoreIC(
// static
-Bytecode BytecodeArrayBuilder::BytecodeForStoreGlobal(
- LanguageMode language_mode) {
- switch (language_mode) {
- case SLOPPY:
- return Bytecode::kStaGlobalSloppy;
- case STRICT:
- return Bytecode::kStaGlobalStrict;
- case STRONG:
- UNIMPLEMENTED();
- default:
- UNREACHABLE();
- }
- return static_cast<Bytecode>(-1);
-}
-
-
-// static
bool BytecodeArrayBuilder::FitsInIdx8Operand(int value) {
return kMinUInt8 <= value && value <= kMaxUInt8;
}
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698