Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index fd7f5e6b93a00d2867f4a00f3d40b905038e250b..5e242858891276a12a4a43fe53e544169b8d20d1 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -5716,16 +5716,6 @@ void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
instr->SetDependsOnFlag(kGlobalVars);
return ast_context()->ReturnInstruction(instr, expr->id());
}
- } else if (variable->IsGlobalSlot()) {
- DCHECK(variable->index() > 0);
- DCHECK(variable->IsStaticGlobalObjectProperty());
- int slot_index = variable->index();
- int depth = scope()->ContextChainLength(variable->scope());
-
- HLoadGlobalViaContext* instr =
- New<HLoadGlobalViaContext>(depth, slot_index);
- return ast_context()->ReturnInstruction(instr, expr->id());
-
} else {
HValue* global_object = Add<HLoadNamedField>(
context(), nullptr,
@@ -6941,18 +6931,6 @@ void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(
if (instr->HasObservableSideEffects()) {
Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
}
- } else if (var->IsGlobalSlot()) {
- DCHECK(var->index() > 0);
- DCHECK(var->IsStaticGlobalObjectProperty());
- int slot_index = var->index();
- int depth = scope()->ContextChainLength(var->scope());
-
- HStoreGlobalViaContext* instr = Add<HStoreGlobalViaContext>(
- value, depth, slot_index, function_language_mode());
- USE(instr);
- DCHECK(instr->HasObservableSideEffects());
- Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
-
} else {
HValue* global_object = Add<HLoadNamedField>(
context(), nullptr,
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698