src/interpreter/bytecode-array-builder.h - Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/compiler/js-generic-lowering.cc ('K') | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | test/cctest/interpreter/test-bytecode-generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/interpreter/bytecode-array-builder.h

diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h

index 3f2415e1be7a97e2f4d77c90071f9f6c847e6764..cd1c001d30bfa96ac3b73c2976358b0285db087c 100644

--- a/src/interpreter/bytecode-array-builder.h

+++ b/src/interpreter/bytecode-array-builder.h

@@ -184,7 +184,6 @@ class BytecodeArrayBuilder {

static Bytecode BytecodeForKeyedLoadIC(LanguageMode language_mode);

static Bytecode BytecodeForStoreIC(LanguageMode language_mode);

static Bytecode BytecodeForKeyedStoreIC(LanguageMode language_mode);

- static Bytecode BytecodeForStoreGlobal(LanguageMode language_mode);

static bool FitsInIdx8Operand(int value);

static bool FitsInIdx8Operand(size_t value);