src/compiler/js-typed-lowering.cc - Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index a373c17d7a60fe6c2576752f58502576bed6349d..689d36c3e7d67888d463b9170a0a5f8e7f6594fb 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -1048,7 +1048,7 @@ Reduction JSTypedLowering::ReduceJSLoadDynamicGlobal(Node* node) {

Node* fast = graph()->NewNode(

javascript()->LoadGlobal(access.name(), access.feedback(),

access.typeof_mode()),

- context, global, vector, context, state1, state2, global, check_true);

+ global, vector, context, state1, state2, global, check_true);

// Slow case, because variable potentially shadowed. Perform dynamic lookup.

uint32_t check_bitset = DynamicGlobalAccess::kFullCheckRequired;

« src/compiler/js-generic-lowering.cc ('K') | « src/compiler/js-operator.cc ('k') | src/crankshaft/arm/lithium-arm.h » ('j') | test/cctest/interpreter/test-bytecode-generator.cc » ('J')