Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: src/compiler/ast-graph-builder.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.h
diff --git a/src/compiler/ast-graph-builder.h b/src/compiler/ast-graph-builder.h
index 5e0b3f3c3387768b7fd8cc019b0f26a335f17556..8ee44885eaf9a4ee8b3a8c7a4d3db0d4af1aa6d8 100644
--- a/src/compiler/ast-graph-builder.h
+++ b/src/compiler/ast-graph-builder.h
@@ -301,12 +301,10 @@ class AstGraphBuilder : public AstVisitor {
const VectorSlotPair& feedback);
// Builders for global variable loads and stores.
- Node* BuildGlobalLoad(Node* script_context, Node* global, Handle<Name> name,
- const VectorSlotPair& feedback, TypeofMode typeof_mode,
- int slot_index);
- Node* BuildGlobalStore(Node* script_context, Node* global, Handle<Name> name,
- Node* value, const VectorSlotPair& feedback,
- TypeFeedbackId id, int slot_index);
+ Node* BuildGlobalLoad(Node* global, Handle<Name> name,
Benedikt Meurer 2015/10/22 05:03:52 Don't explicitly pass the global object here, but
Igor Sheludko 2015/10/22 08:49:52 Done.
+ const VectorSlotPair& feedback, TypeofMode typeof_mode);
+ Node* BuildGlobalStore(Node* global, Handle<Name> name, Node* value,
Benedikt Meurer 2015/10/22 05:03:52 Don't explicitly pass the global object here, but
Igor Sheludko 2015/10/22 08:49:52 Done.
+ const VectorSlotPair& feedback, TypeFeedbackId id);
// Builders for accessing the function context.
Node* BuildLoadGlobalObject();

Powered by Google App Engine
This is Rietveld 408576698