Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: src/crankshaft/x64/lithium-x64.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-codegen-x64.cc ('k') | src/crankshaft/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_X64_LITHIUM_X64_H_ 5 #ifndef V8_CRANKSHAFT_X64_LITHIUM_X64_H_
6 #define V8_CRANKSHAFT_X64_LITHIUM_X64_H_ 6 #define V8_CRANKSHAFT_X64_LITHIUM_X64_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 V(IsStringAndBranch) \ 93 V(IsStringAndBranch) \
94 V(IsSmiAndBranch) \ 94 V(IsSmiAndBranch) \
95 V(IsUndetectableAndBranch) \ 95 V(IsUndetectableAndBranch) \
96 V(Label) \ 96 V(Label) \
97 V(LazyBailout) \ 97 V(LazyBailout) \
98 V(LoadContextSlot) \ 98 V(LoadContextSlot) \
99 V(LoadRoot) \ 99 V(LoadRoot) \
100 V(LoadFieldByIndex) \ 100 V(LoadFieldByIndex) \
101 V(LoadFunctionPrototype) \ 101 V(LoadFunctionPrototype) \
102 V(LoadGlobalGeneric) \ 102 V(LoadGlobalGeneric) \
103 V(LoadGlobalViaContext) \
104 V(LoadKeyed) \ 103 V(LoadKeyed) \
105 V(LoadKeyedGeneric) \ 104 V(LoadKeyedGeneric) \
106 V(LoadNamedField) \ 105 V(LoadNamedField) \
107 V(LoadNamedGeneric) \ 106 V(LoadNamedGeneric) \
108 V(MapEnumLength) \ 107 V(MapEnumLength) \
109 V(MathAbs) \ 108 V(MathAbs) \
110 V(MathClz32) \ 109 V(MathClz32) \
111 V(MathExp) \ 110 V(MathExp) \
112 V(MathFloor) \ 111 V(MathFloor) \
113 V(MathFround) \ 112 V(MathFround) \
(...skipping 20 matching lines...) Expand all
134 V(Return) \ 133 V(Return) \
135 V(SeqStringGetChar) \ 134 V(SeqStringGetChar) \
136 V(SeqStringSetChar) \ 135 V(SeqStringSetChar) \
137 V(ShiftI) \ 136 V(ShiftI) \
138 V(SmiTag) \ 137 V(SmiTag) \
139 V(SmiUntag) \ 138 V(SmiUntag) \
140 V(StackCheck) \ 139 V(StackCheck) \
141 V(StoreCodeEntry) \ 140 V(StoreCodeEntry) \
142 V(StoreContextSlot) \ 141 V(StoreContextSlot) \
143 V(StoreFrameContext) \ 142 V(StoreFrameContext) \
144 V(StoreGlobalViaContext) \
145 V(StoreKeyed) \ 143 V(StoreKeyed) \
146 V(StoreKeyedGeneric) \ 144 V(StoreKeyedGeneric) \
147 V(StoreNamedField) \ 145 V(StoreNamedField) \
148 V(StoreNamedGeneric) \ 146 V(StoreNamedGeneric) \
149 V(StringAdd) \ 147 V(StringAdd) \
150 V(StringCharCodeAt) \ 148 V(StringCharCodeAt) \
151 V(StringCharFromCode) \ 149 V(StringCharFromCode) \
152 V(StringCompareAndBranch) \ 150 V(StringCompareAndBranch) \
153 V(SubI) \ 151 V(SubI) \
154 V(TaggedToI) \ 152 V(TaggedToI) \
(...skipping 1498 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 1651
1654 LOperand* context() { return inputs_[0]; } 1652 LOperand* context() { return inputs_[0]; }
1655 LOperand* global_object() { return inputs_[1]; } 1653 LOperand* global_object() { return inputs_[1]; }
1656 LOperand* temp_vector() { return temps_[0]; } 1654 LOperand* temp_vector() { return temps_[0]; }
1657 1655
1658 Handle<Object> name() const { return hydrogen()->name(); } 1656 Handle<Object> name() const { return hydrogen()->name(); }
1659 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); } 1657 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); }
1660 }; 1658 };
1661 1659
1662 1660
1663 class LLoadGlobalViaContext final : public LTemplateInstruction<1, 1, 1> {
1664 public:
1665 explicit LLoadGlobalViaContext(LOperand* context) { inputs_[0] = context; }
1666
1667 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext, "load-global-via-context")
1668 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalViaContext)
1669
1670 void PrintDataTo(StringStream* stream) override;
1671
1672 LOperand* context() { return inputs_[0]; }
1673
1674 int depth() const { return hydrogen()->depth(); }
1675 int slot_index() const { return hydrogen()->slot_index(); }
1676 };
1677
1678
1679 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> { 1661 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> {
1680 public: 1662 public:
1681 explicit LLoadContextSlot(LOperand* context) { 1663 explicit LLoadContextSlot(LOperand* context) {
1682 inputs_[0] = context; 1664 inputs_[0] = context;
1683 } 1665 }
1684 1666
1685 LOperand* context() { return inputs_[0]; } 1667 LOperand* context() { return inputs_[0]; }
1686 1668
1687 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1669 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1688 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1670 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
2160 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic") 2142 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic")
2161 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric) 2143 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric)
2162 2144
2163 void PrintDataTo(StringStream* stream) override; 2145 void PrintDataTo(StringStream* stream) override;
2164 2146
2165 Handle<Object> name() const { return hydrogen()->name(); } 2147 Handle<Object> name() const { return hydrogen()->name(); }
2166 LanguageMode language_mode() { return hydrogen()->language_mode(); } 2148 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2167 }; 2149 };
2168 2150
2169 2151
2170 class LStoreGlobalViaContext final : public LTemplateInstruction<0, 2, 0> {
2171 public:
2172 LStoreGlobalViaContext(LOperand* context, LOperand* value) {
2173 inputs_[0] = context;
2174 inputs_[1] = value;
2175 }
2176
2177 LOperand* context() { return inputs_[0]; }
2178 LOperand* value() { return inputs_[1]; }
2179
2180 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext,
2181 "store-global-via-context")
2182 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalViaContext)
2183
2184 void PrintDataTo(StringStream* stream) override;
2185
2186 int depth() { return hydrogen()->depth(); }
2187 int slot_index() { return hydrogen()->slot_index(); }
2188 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2189 };
2190
2191
2192 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> { 2152 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> {
2193 public: 2153 public:
2194 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value) { 2154 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value) {
2195 inputs_[0] = object; 2155 inputs_[0] = object;
2196 inputs_[1] = key; 2156 inputs_[1] = key;
2197 inputs_[2] = value; 2157 inputs_[2] = value;
2198 } 2158 }
2199 2159
2200 bool is_fixed_typed_array() const { 2160 bool is_fixed_typed_array() const {
2201 return hydrogen()->is_fixed_typed_array(); 2161 return hydrogen()->is_fixed_typed_array();
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
2861 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2821 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2862 }; 2822 };
2863 2823
2864 #undef DECLARE_HYDROGEN_ACCESSOR 2824 #undef DECLARE_HYDROGEN_ACCESSOR
2865 #undef DECLARE_CONCRETE_INSTRUCTION 2825 #undef DECLARE_CONCRETE_INSTRUCTION
2866 2826
2867 } // namespace internal 2827 } // namespace internal
2868 } // namespace v8 2828 } // namespace v8
2869 2829
2870 #endif // V8_CRANKSHAFT_X64_LITHIUM_X64_H_ 2830 #endif // V8_CRANKSHAFT_X64_LITHIUM_X64_H_
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-codegen-x64.cc ('k') | src/crankshaft/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698