Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/crankshaft/ppc/lithium-ppc.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/ppc/lithium-ppc.h" 5 #include "src/crankshaft/ppc/lithium-ppc.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/lithium-inl.h" 10 #include "src/crankshaft/lithium-inl.h"
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 329
330 void LAccessArgumentsAt::PrintDataTo(StringStream* stream) { 330 void LAccessArgumentsAt::PrintDataTo(StringStream* stream) {
331 arguments()->PrintTo(stream); 331 arguments()->PrintTo(stream);
332 stream->Add(" length "); 332 stream->Add(" length ");
333 length()->PrintTo(stream); 333 length()->PrintTo(stream);
334 stream->Add(" index "); 334 stream->Add(" index ");
335 index()->PrintTo(stream); 335 index()->PrintTo(stream);
336 } 336 }
337 337
338 338
339 void LLoadGlobalViaContext::PrintDataTo(StringStream* stream) {
340 stream->Add("depth:%d slot:%d", depth(), slot_index());
341 }
342
343
344 void LStoreNamedField::PrintDataTo(StringStream* stream) { 339 void LStoreNamedField::PrintDataTo(StringStream* stream) {
345 object()->PrintTo(stream); 340 object()->PrintTo(stream);
346 std::ostringstream os; 341 std::ostringstream os;
347 os << hydrogen()->access() << " <- "; 342 os << hydrogen()->access() << " <- ";
348 stream->Add(os.str().c_str()); 343 stream->Add(os.str().c_str());
349 value()->PrintTo(stream); 344 value()->PrintTo(stream);
350 } 345 }
351 346
352 347
353 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) { 348 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
354 object()->PrintTo(stream); 349 object()->PrintTo(stream);
355 stream->Add("."); 350 stream->Add(".");
356 stream->Add(String::cast(*name())->ToCString().get()); 351 stream->Add(String::cast(*name())->ToCString().get());
357 stream->Add(" <- "); 352 stream->Add(" <- ");
358 value()->PrintTo(stream); 353 value()->PrintTo(stream);
359 } 354 }
360 355
361 356
362 void LStoreGlobalViaContext::PrintDataTo(StringStream* stream) {
363 stream->Add("depth:%d slot:%d <- ", depth(), slot_index());
364 value()->PrintTo(stream);
365 }
366
367
368 void LLoadKeyed::PrintDataTo(StringStream* stream) { 357 void LLoadKeyed::PrintDataTo(StringStream* stream) {
369 elements()->PrintTo(stream); 358 elements()->PrintTo(stream);
370 stream->Add("["); 359 stream->Add("[");
371 key()->PrintTo(stream); 360 key()->PrintTo(stream);
372 if (hydrogen()->IsDehoisted()) { 361 if (hydrogen()->IsDehoisted()) {
373 stream->Add(" + %d]", base_offset()); 362 stream->Add(" + %d]", base_offset());
374 } else { 363 } else {
375 stream->Add("]"); 364 stream->Add("]");
376 } 365 }
377 } 366 }
(...skipping 1716 matching lines...) Expand 10 before | Expand all | Expand 10 after
2094 LOperand* vector = NULL; 2083 LOperand* vector = NULL;
2095 if (instr->HasVectorAndSlot()) { 2084 if (instr->HasVectorAndSlot()) {
2096 vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister()); 2085 vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2097 } 2086 }
2098 LLoadGlobalGeneric* result = 2087 LLoadGlobalGeneric* result =
2099 new (zone()) LLoadGlobalGeneric(context, global_object, vector); 2088 new (zone()) LLoadGlobalGeneric(context, global_object, vector);
2100 return MarkAsCall(DefineFixed(result, r3), instr); 2089 return MarkAsCall(DefineFixed(result, r3), instr);
2101 } 2090 }
2102 2091
2103 2092
2104 LInstruction* LChunkBuilder::DoLoadGlobalViaContext(
2105 HLoadGlobalViaContext* instr) {
2106 LOperand* context = UseFixed(instr->context(), cp);
2107 DCHECK(instr->slot_index() > 0);
2108 LLoadGlobalViaContext* result = new (zone()) LLoadGlobalViaContext(context);
2109 return MarkAsCall(DefineFixed(result, r3), instr);
2110 }
2111
2112
2113 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 2093 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
2114 LOperand* context = UseRegisterAtStart(instr->value()); 2094 LOperand* context = UseRegisterAtStart(instr->value());
2115 LInstruction* result = 2095 LInstruction* result =
2116 DefineAsRegister(new (zone()) LLoadContextSlot(context)); 2096 DefineAsRegister(new (zone()) LLoadContextSlot(context));
2117 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) { 2097 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
2118 result = AssignEnvironment(result); 2098 result = AssignEnvironment(result);
2119 } 2099 }
2120 return result; 2100 return result;
2121 } 2101 }
2122 2102
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
2379 slot = FixedTemp(VectorStoreICDescriptor::SlotRegister()); 2359 slot = FixedTemp(VectorStoreICDescriptor::SlotRegister());
2380 vector = FixedTemp(VectorStoreICDescriptor::VectorRegister()); 2360 vector = FixedTemp(VectorStoreICDescriptor::VectorRegister());
2381 } 2361 }
2382 2362
2383 LStoreNamedGeneric* result = 2363 LStoreNamedGeneric* result =
2384 new (zone()) LStoreNamedGeneric(context, obj, val, slot, vector); 2364 new (zone()) LStoreNamedGeneric(context, obj, val, slot, vector);
2385 return MarkAsCall(result, instr); 2365 return MarkAsCall(result, instr);
2386 } 2366 }
2387 2367
2388 2368
2389 LInstruction* LChunkBuilder::DoStoreGlobalViaContext(
2390 HStoreGlobalViaContext* instr) {
2391 LOperand* context = UseFixed(instr->context(), cp);
2392 LOperand* value = UseFixed(instr->value(),
2393 StoreGlobalViaContextDescriptor::ValueRegister());
2394 DCHECK(instr->slot_index() > 0);
2395
2396 LStoreGlobalViaContext* result =
2397 new (zone()) LStoreGlobalViaContext(context, value);
2398 return MarkAsCall(result, instr);
2399 }
2400
2401
2402 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2369 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2403 LOperand* context = UseFixed(instr->context(), cp); 2370 LOperand* context = UseFixed(instr->context(), cp);
2404 LOperand* left = UseFixed(instr->left(), r4); 2371 LOperand* left = UseFixed(instr->left(), r4);
2405 LOperand* right = UseFixed(instr->right(), r3); 2372 LOperand* right = UseFixed(instr->right(), r3);
2406 return MarkAsCall( 2373 return MarkAsCall(
2407 DefineFixed(new (zone()) LStringAdd(context, left, right), r3), instr); 2374 DefineFixed(new (zone()) LStringAdd(context, left, right), r3), instr);
2408 } 2375 }
2409 2376
2410 2377
2411 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 2378 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
2642 LInstruction* LChunkBuilder::DoAllocateBlockContext( 2609 LInstruction* LChunkBuilder::DoAllocateBlockContext(
2643 HAllocateBlockContext* instr) { 2610 HAllocateBlockContext* instr) {
2644 LOperand* context = UseFixed(instr->context(), cp); 2611 LOperand* context = UseFixed(instr->context(), cp);
2645 LOperand* function = UseRegisterAtStart(instr->function()); 2612 LOperand* function = UseRegisterAtStart(instr->function());
2646 LAllocateBlockContext* result = 2613 LAllocateBlockContext* result =
2647 new (zone()) LAllocateBlockContext(context, function); 2614 new (zone()) LAllocateBlockContext(context, function);
2648 return MarkAsCall(DefineFixed(result, cp), instr); 2615 return MarkAsCall(DefineFixed(result, cp), instr);
2649 } 2616 }
2650 } // namespace internal 2617 } // namespace internal
2651 } // namespace v8 2618 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ppc/lithium-ppc.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698