Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/crankshaft/ia32/lithium-ia32.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 V(IsConstructCallAndBranch) \ 96 V(IsConstructCallAndBranch) \
97 V(IsStringAndBranch) \ 97 V(IsStringAndBranch) \
98 V(IsSmiAndBranch) \ 98 V(IsSmiAndBranch) \
99 V(IsUndetectableAndBranch) \ 99 V(IsUndetectableAndBranch) \
100 V(Label) \ 100 V(Label) \
101 V(LazyBailout) \ 101 V(LazyBailout) \
102 V(LoadContextSlot) \ 102 V(LoadContextSlot) \
103 V(LoadFieldByIndex) \ 103 V(LoadFieldByIndex) \
104 V(LoadFunctionPrototype) \ 104 V(LoadFunctionPrototype) \
105 V(LoadGlobalGeneric) \ 105 V(LoadGlobalGeneric) \
106 V(LoadGlobalViaContext) \
107 V(LoadKeyed) \ 106 V(LoadKeyed) \
108 V(LoadKeyedGeneric) \ 107 V(LoadKeyedGeneric) \
109 V(LoadNamedField) \ 108 V(LoadNamedField) \
110 V(LoadNamedGeneric) \ 109 V(LoadNamedGeneric) \
111 V(LoadRoot) \ 110 V(LoadRoot) \
112 V(MapEnumLength) \ 111 V(MapEnumLength) \
113 V(MathAbs) \ 112 V(MathAbs) \
114 V(MathClz32) \ 113 V(MathClz32) \
115 V(MathExp) \ 114 V(MathExp) \
116 V(MathFloor) \ 115 V(MathFloor) \
(...skipping 21 matching lines...) Expand all
138 V(Return) \ 137 V(Return) \
139 V(SeqStringGetChar) \ 138 V(SeqStringGetChar) \
140 V(SeqStringSetChar) \ 139 V(SeqStringSetChar) \
141 V(ShiftI) \ 140 V(ShiftI) \
142 V(SmiTag) \ 141 V(SmiTag) \
143 V(SmiUntag) \ 142 V(SmiUntag) \
144 V(StackCheck) \ 143 V(StackCheck) \
145 V(StoreCodeEntry) \ 144 V(StoreCodeEntry) \
146 V(StoreContextSlot) \ 145 V(StoreContextSlot) \
147 V(StoreFrameContext) \ 146 V(StoreFrameContext) \
148 V(StoreGlobalViaContext) \
149 V(StoreKeyed) \ 147 V(StoreKeyed) \
150 V(StoreKeyedGeneric) \ 148 V(StoreKeyedGeneric) \
151 V(StoreNamedField) \ 149 V(StoreNamedField) \
152 V(StoreNamedGeneric) \ 150 V(StoreNamedGeneric) \
153 V(StringAdd) \ 151 V(StringAdd) \
154 V(StringCharCodeAt) \ 152 V(StringCharCodeAt) \
155 V(StringCharFromCode) \ 153 V(StringCharFromCode) \
156 V(StringCompareAndBranch) \ 154 V(StringCompareAndBranch) \
157 V(SubI) \ 155 V(SubI) \
158 V(TaggedToI) \ 156 V(TaggedToI) \
(...skipping 1521 matching lines...) Expand 10 before | Expand all | Expand 10 after
1680 LOperand* temp_vector() { return temps_[0]; } 1678 LOperand* temp_vector() { return temps_[0]; }
1681 1679
1682 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalGeneric, "load-global-generic") 1680 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalGeneric, "load-global-generic")
1683 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalGeneric) 1681 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalGeneric)
1684 1682
1685 Handle<Object> name() const { return hydrogen()->name(); } 1683 Handle<Object> name() const { return hydrogen()->name(); }
1686 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); } 1684 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); }
1687 }; 1685 };
1688 1686
1689 1687
1690 class LLoadGlobalViaContext final : public LTemplateInstruction<1, 1, 1> {
1691 public:
1692 explicit LLoadGlobalViaContext(LOperand* context) { inputs_[0] = context; }
1693
1694 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext, "load-global-via-context")
1695 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalViaContext)
1696
1697 void PrintDataTo(StringStream* stream) override;
1698
1699 LOperand* context() { return inputs_[0]; }
1700
1701 int depth() const { return hydrogen()->depth(); }
1702 int slot_index() const { return hydrogen()->slot_index(); }
1703 };
1704
1705
1706 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> { 1688 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> {
1707 public: 1689 public:
1708 explicit LLoadContextSlot(LOperand* context) { 1690 explicit LLoadContextSlot(LOperand* context) {
1709 inputs_[0] = context; 1691 inputs_[0] = context;
1710 } 1692 }
1711 1693
1712 LOperand* context() { return inputs_[0]; } 1694 LOperand* context() { return inputs_[0]; }
1713 1695
1714 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1696 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1715 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1697 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
2188 2170
2189 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic") 2171 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic")
2190 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric) 2172 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric)
2191 2173
2192 void PrintDataTo(StringStream* stream) override; 2174 void PrintDataTo(StringStream* stream) override;
2193 Handle<Object> name() const { return hydrogen()->name(); } 2175 Handle<Object> name() const { return hydrogen()->name(); }
2194 LanguageMode language_mode() { return hydrogen()->language_mode(); } 2176 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2195 }; 2177 };
2196 2178
2197 2179
2198 class LStoreGlobalViaContext final : public LTemplateInstruction<0, 2, 0> {
2199 public:
2200 LStoreGlobalViaContext(LOperand* context, LOperand* value) {
2201 inputs_[0] = context;
2202 inputs_[1] = value;
2203 }
2204
2205 LOperand* context() { return inputs_[0]; }
2206 LOperand* value() { return inputs_[1]; }
2207
2208 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext,
2209 "store-global-via-context")
2210 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalViaContext)
2211
2212 void PrintDataTo(StringStream* stream) override;
2213
2214 int depth() { return hydrogen()->depth(); }
2215 int slot_index() { return hydrogen()->slot_index(); }
2216 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2217 };
2218
2219
2220 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> { 2180 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> {
2221 public: 2181 public:
2222 LStoreKeyed(LOperand* obj, LOperand* key, LOperand* val) { 2182 LStoreKeyed(LOperand* obj, LOperand* key, LOperand* val) {
2223 inputs_[0] = obj; 2183 inputs_[0] = obj;
2224 inputs_[1] = key; 2184 inputs_[1] = key;
2225 inputs_[2] = val; 2185 inputs_[2] = val;
2226 } 2186 }
2227 2187
2228 bool is_fixed_typed_array() const { 2188 bool is_fixed_typed_array() const {
2229 return hydrogen()->is_fixed_typed_array(); 2189 return hydrogen()->is_fixed_typed_array();
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
2882 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2842 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2883 }; 2843 };
2884 2844
2885 #undef DECLARE_HYDROGEN_ACCESSOR 2845 #undef DECLARE_HYDROGEN_ACCESSOR
2886 #undef DECLARE_CONCRETE_INSTRUCTION 2846 #undef DECLARE_CONCRETE_INSTRUCTION
2887 2847
2888 } // namespace internal 2848 } // namespace internal
2889 } // namespace v8 2849 } // namespace v8
2890 2850
2891 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 2851 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698