Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Side by Side Diff: src/crankshaft/arm/lithium-arm.h

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 5 #ifndef V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
6 #define V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 6 #define V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 V(IsStringAndBranch) \ 93 V(IsStringAndBranch) \
94 V(IsSmiAndBranch) \ 94 V(IsSmiAndBranch) \
95 V(IsUndetectableAndBranch) \ 95 V(IsUndetectableAndBranch) \
96 V(Label) \ 96 V(Label) \
97 V(LazyBailout) \ 97 V(LazyBailout) \
98 V(LoadContextSlot) \ 98 V(LoadContextSlot) \
99 V(LoadRoot) \ 99 V(LoadRoot) \
100 V(LoadFieldByIndex) \ 100 V(LoadFieldByIndex) \
101 V(LoadFunctionPrototype) \ 101 V(LoadFunctionPrototype) \
102 V(LoadGlobalGeneric) \ 102 V(LoadGlobalGeneric) \
103 V(LoadGlobalViaContext) \
104 V(LoadKeyed) \ 103 V(LoadKeyed) \
105 V(LoadKeyedGeneric) \ 104 V(LoadKeyedGeneric) \
106 V(LoadNamedField) \ 105 V(LoadNamedField) \
107 V(LoadNamedGeneric) \ 106 V(LoadNamedGeneric) \
108 V(MapEnumLength) \ 107 V(MapEnumLength) \
109 V(MathAbs) \ 108 V(MathAbs) \
110 V(MathClz32) \ 109 V(MathClz32) \
111 V(MathExp) \ 110 V(MathExp) \
112 V(MathFloor) \ 111 V(MathFloor) \
113 V(MathFround) \ 112 V(MathFround) \
(...skipping 22 matching lines...) Expand all
136 V(Return) \ 135 V(Return) \
137 V(SeqStringGetChar) \ 136 V(SeqStringGetChar) \
138 V(SeqStringSetChar) \ 137 V(SeqStringSetChar) \
139 V(ShiftI) \ 138 V(ShiftI) \
140 V(SmiTag) \ 139 V(SmiTag) \
141 V(SmiUntag) \ 140 V(SmiUntag) \
142 V(StackCheck) \ 141 V(StackCheck) \
143 V(StoreCodeEntry) \ 142 V(StoreCodeEntry) \
144 V(StoreContextSlot) \ 143 V(StoreContextSlot) \
145 V(StoreFrameContext) \ 144 V(StoreFrameContext) \
146 V(StoreGlobalViaContext) \
147 V(StoreKeyed) \ 145 V(StoreKeyed) \
148 V(StoreKeyedGeneric) \ 146 V(StoreKeyedGeneric) \
149 V(StoreNamedField) \ 147 V(StoreNamedField) \
150 V(StoreNamedGeneric) \ 148 V(StoreNamedGeneric) \
151 V(StringAdd) \ 149 V(StringAdd) \
152 V(StringCharCodeAt) \ 150 V(StringCharCodeAt) \
153 V(StringCharFromCode) \ 151 V(StringCharFromCode) \
154 V(StringCompareAndBranch) \ 152 V(StringCompareAndBranch) \
155 V(SubI) \ 153 V(SubI) \
156 V(RSubI) \ 154 V(RSubI) \
(...skipping 1508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1665 LOperand* temp_vector() { return temps_[0]; } 1663 LOperand* temp_vector() { return temps_[0]; }
1666 1664
1667 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalGeneric, "load-global-generic") 1665 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalGeneric, "load-global-generic")
1668 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalGeneric) 1666 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalGeneric)
1669 1667
1670 Handle<Object> name() const { return hydrogen()->name(); } 1668 Handle<Object> name() const { return hydrogen()->name(); }
1671 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); } 1669 TypeofMode typeof_mode() const { return hydrogen()->typeof_mode(); }
1672 }; 1670 };
1673 1671
1674 1672
1675 class LLoadGlobalViaContext final : public LTemplateInstruction<1, 1, 1> {
1676 public:
1677 explicit LLoadGlobalViaContext(LOperand* context) { inputs_[0] = context; }
1678
1679 DECLARE_CONCRETE_INSTRUCTION(LoadGlobalViaContext, "load-global-via-context")
1680 DECLARE_HYDROGEN_ACCESSOR(LoadGlobalViaContext)
1681
1682 void PrintDataTo(StringStream* stream) override;
1683
1684 LOperand* context() { return inputs_[0]; }
1685
1686 int depth() const { return hydrogen()->depth(); }
1687 int slot_index() const { return hydrogen()->slot_index(); }
1688 };
1689
1690
1691 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> { 1673 class LLoadContextSlot final : public LTemplateInstruction<1, 1, 0> {
1692 public: 1674 public:
1693 explicit LLoadContextSlot(LOperand* context) { 1675 explicit LLoadContextSlot(LOperand* context) {
1694 inputs_[0] = context; 1676 inputs_[0] = context;
1695 } 1677 }
1696 1678
1697 LOperand* context() { return inputs_[0]; } 1679 LOperand* context() { return inputs_[0]; }
1698 1680
1699 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1681 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1700 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1682 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
2182 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic") 2164 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic")
2183 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric) 2165 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric)
2184 2166
2185 void PrintDataTo(StringStream* stream) override; 2167 void PrintDataTo(StringStream* stream) override;
2186 2168
2187 Handle<Object> name() const { return hydrogen()->name(); } 2169 Handle<Object> name() const { return hydrogen()->name(); }
2188 LanguageMode language_mode() { return hydrogen()->language_mode(); } 2170 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2189 }; 2171 };
2190 2172
2191 2173
2192 class LStoreGlobalViaContext final : public LTemplateInstruction<0, 2, 0> {
2193 public:
2194 LStoreGlobalViaContext(LOperand* context, LOperand* value) {
2195 inputs_[0] = context;
2196 inputs_[1] = value;
2197 }
2198
2199 LOperand* context() { return inputs_[0]; }
2200 LOperand* value() { return inputs_[1]; }
2201
2202 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalViaContext,
2203 "store-global-via-context")
2204 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalViaContext)
2205
2206 void PrintDataTo(StringStream* stream) override;
2207
2208 int depth() { return hydrogen()->depth(); }
2209 int slot_index() { return hydrogen()->slot_index(); }
2210 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2211 };
2212
2213
2214 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> { 2174 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> {
2215 public: 2175 public:
2216 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value) { 2176 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value) {
2217 inputs_[0] = object; 2177 inputs_[0] = object;
2218 inputs_[1] = key; 2178 inputs_[1] = key;
2219 inputs_[2] = value; 2179 inputs_[2] = value;
2220 } 2180 }
2221 2181
2222 bool is_fixed_typed_array() const { 2182 bool is_fixed_typed_array() const {
2223 return hydrogen()->is_fixed_typed_array(); 2183 return hydrogen()->is_fixed_typed_array();
(...skipping 658 matching lines...) Expand 10 before | Expand all | Expand 10 after
2882 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2842 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2883 }; 2843 };
2884 2844
2885 #undef DECLARE_HYDROGEN_ACCESSOR 2845 #undef DECLARE_HYDROGEN_ACCESSOR
2886 #undef DECLARE_CONCRETE_INSTRUCTION 2846 #undef DECLARE_CONCRETE_INSTRUCTION
2887 2847
2888 } // namespace internal 2848 } // namespace internal
2889 } // namespace v8 2849 } // namespace v8
2890 2850
2891 #endif // V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 2851 #endif // V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698