Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: src/code-factory.cc

Issue 1419823003: Remove support for "loads and stores to global vars through property cell shortcuts inst… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@disable-shortcuts
Patch Set: Addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 // static 132 // static
133 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op, 133 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op,
134 Strength strength) { 134 Strength strength) {
135 BinaryOpICStub stub(isolate, op, strength); 135 BinaryOpICStub stub(isolate, op, strength);
136 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 136 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
137 } 137 }
138 138
139 139
140 // static 140 // static
141 Callable CodeFactory::LoadGlobalViaContext(Isolate* isolate, int depth) {
142 LoadGlobalViaContextStub stub(isolate, depth);
143 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
144 }
145
146
147 // static
148 Callable CodeFactory::StoreGlobalViaContext(Isolate* isolate, int depth,
149 LanguageMode language_mode) {
150 StoreGlobalViaContextStub stub(isolate, depth, language_mode);
151 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
152 }
153
154
155 // static
156 Callable CodeFactory::InstanceOf(Isolate* isolate) { 141 Callable CodeFactory::InstanceOf(Isolate* isolate) {
157 InstanceOfStub stub(isolate); 142 InstanceOfStub stub(isolate);
158 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 143 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
159 } 144 }
160 145
161 146
162 // static 147 // static
163 Callable CodeFactory::ToBoolean(Isolate* isolate, 148 Callable CodeFactory::ToBoolean(Isolate* isolate,
164 ToBooleanStub::ResultMode mode, 149 ToBooleanStub::ResultMode mode,
165 ToBooleanStub::Types types) { 150 ToBooleanStub::Types types) {
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 Callable CodeFactory::InterpreterCEntry(Isolate* isolate) { 299 Callable CodeFactory::InterpreterCEntry(Isolate* isolate) {
315 // TODO(rmcilroy): Deal with runtime functions that return two values. 300 // TODO(rmcilroy): Deal with runtime functions that return two values.
316 // Note: If we ever use fpregs in the interpreter then we will need to 301 // Note: If we ever use fpregs in the interpreter then we will need to
317 // save fpregs too. 302 // save fpregs too.
318 CEntryStub stub(isolate, 1, kDontSaveFPRegs, kArgvInRegister); 303 CEntryStub stub(isolate, 1, kDontSaveFPRegs, kArgvInRegister);
319 return Callable(stub.GetCode(), InterpreterCEntryDescriptor(isolate)); 304 return Callable(stub.GetCode(), InterpreterCEntryDescriptor(isolate));
320 } 305 }
321 306
322 } // namespace internal 307 } // namespace internal
323 } // namespace v8 308 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-factory.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698