|
|
DescriptionRun telemetry_perf_unittest via isolate on Windows tests with swarming
*BUILD SHERRIF: if the windows bots fail
telemetry_perf_unittest, it's probably safe to revert this
patch.
The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py
is addressed in https://codereview.chromium.org/1411843011/
and will be rebased before submitting.
BUG=507796
NOTRY=true
Committed: https://crrev.com/7824fdeb349810e8df7f1954636fc57a01540c05
Cr-Commit-Position: refs/heads/master@{#358717}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming BUG= ========== to ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 ==========
nednguyen@google.com changed reviewers: + maruel@chromium.org
lgtm https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/i... File tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py (right): https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/i... tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139: self._backend.CloseMsrServer() Do you think you need to use try/finally but it's fine?
https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/i... File tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py (right): https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/i... tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139: self._backend.CloseMsrServer() On 2015/11/09 19:08:16, M-A Ruel wrote: > Do you think you need to use try/finally but it's fine? Good point, I will address this with Dave in a different patch.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1419813012/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
Description was changed from ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 ========== to ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming *BUILD SHERRIF: if the windows bots fail telemetry_perf_unittest, it's probably safe to revert this patch. The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
Description was changed from ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming *BUILD SHERRIF: if the windows bots fail telemetry_perf_unittest, it's probably safe to revert this patch. The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 ========== to ========== Run telemetry_perf_unittest via isolate on Windows tests with swarming *BUILD SHERRIF: if the windows bots fail telemetry_perf_unittest, it's probably safe to revert this patch. The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 NOTRY=true ==========
On 2015/11/09 22:20:44, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001 Added NOTRY=true because linux_blink_oilpan_rel timing out and this change should not affect any test suites run by that bot.
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7824fdeb349810e8df7f1954636fc57a01540c05 Cr-Commit-Position: refs/heads/master@{#358717} |