Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1419813012: Run telemetry_perf_unittest via isolate on Windows tests with swarming (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run telemetry_perf_unittest via isolate on Windows tests with swarming *BUILD SHERRIF: if the windows bots fail telemetry_perf_unittest, it's probably safe to revert this patch. The change to tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py is addressed in https://codereview.chromium.org/1411843011/ and will be rebased before submitting. BUG=507796 NOTRY=true Committed: https://crrev.com/7824fdeb349810e8df7f1954636fc57a01540c05 Cr-Commit-Position: refs/heads/master@{#358717}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M testing/buildbot/chromium.win.json View 7 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
nednguyen
5 years, 1 month ago (2015-11-09 18:53:57 UTC) #3
M-A Ruel
lgtm https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py (right): https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py#newcode139 tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139: self._backend.CloseMsrServer() Do you think you need to use ...
5 years, 1 month ago (2015-11-09 19:08:16 UTC) #4
nednguyen
https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py (right): https://codereview.chromium.org/1419813012/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py#newcode139 tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139: self._backend.CloseMsrServer() On 2015/11/09 19:08:16, M-A Ruel wrote: > Do ...
5 years, 1 month ago (2015-11-09 19:35:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
5 years, 1 month ago (2015-11-09 21:19:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/1682)
5 years, 1 month ago (2015-11-09 22:16:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
5 years, 1 month ago (2015-11-09 22:20:44 UTC) #13
nednguyen
On 2015/11/09 22:20:44, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 1 month ago (2015-11-09 23:44:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
5 years, 1 month ago (2015-11-09 23:47:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813012/20001
5 years, 1 month ago (2015-11-10 00:19:28 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 00:40:36 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:41:54 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7824fdeb349810e8df7f1954636fc57a01540c05
Cr-Commit-Position: refs/heads/master@{#358717}

Powered by Google App Engine
This is Rietveld 408576698