[runtime] Remove the very dangerous %_CallFunction intrinsic.

src/js/i18n.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ECMAScript 402 API implementation.
 
 /**
  * Intl object is a single object that has some named properties,
  * all of which are constructors.
  */
@@ skipping 231 matching lines @@
     configurable: true
   });
 }
 
 
 /**
  * Returns an intersection of locales and service supported locales.
  * Parameter locales is treated as a priority list.
  */
 function supportedLocalesOf(service, locales, options) {
-  if (IS_NULL(%_CallFunction(service, GetServiceRE(), StringMatch))) {
+  if (IS_NULL(%_Call(StringMatch, service, GetServiceRE()))) {
     throw MakeError(kWrongServiceType, service);
   }
 
   // Provide defaults if matcher was not specified.
   if (IS_UNDEFINED(options)) {
     options = {};
   } else {
     options = TO_OBJECT(options);
   }
 
@@ skipping 27 matching lines @@
 
 /**
  * Returns the subset of the provided BCP 47 language priority list for which
  * this service has a matching locale when using the BCP 47 Lookup algorithm.
  * Locales appear in the same order in the returned list as in the input list.
  */
 function lookupSupportedLocalesOf(requestedLocales, availableLocales) {
   var matchedLocales = [];
   for (var i = 0; i < requestedLocales.length; ++i) {
     // Remove -u- extension.
-    var locale = %_CallFunction(requestedLocales[i], GetUnicodeExtensionRE(),
-                                '', StringReplace);
+    var locale = %_Call(StringReplace,
+                        requestedLocales[i],
+                        GetUnicodeExtensionRE(),
+                        '');
     do {
       if (!IS_UNDEFINED(availableLocales[locale])) {
         // Push requested locale not the resolved one.
-        %_CallFunction(matchedLocales, requestedLocales[i], ArrayPush);
+        %_Call(ArrayPush, matchedLocales, requestedLocales[i]);
         break;
       }
       // Truncate locale if possible, if not break.
-      var pos = %_CallFunction(locale, '-', StringLastIndexOf);
+      var pos = %_Call(StringLastIndexOf, locale, '-');
       if (pos === -1) {
         break;
       }
-      locale = %_CallFunction(locale, 0, pos, StringSubstring);
+      locale = %_Call(StringSubstring, locale, 0, pos);
     } while (true);
   }
 
   return matchedLocales;
 }
 
 
 /**
  * Returns the subset of the provided BCP 47 language priority list for which
  * this service has a matching locale when using the implementation
@@ skipping 24 matching lines @@
         case 'string':
           value = GlobalString(value);
           break;
         case 'number':
           value = GlobalNumber(value);
           break;
         default:
           throw MakeError(kWrongValueType);
       }
 
-      if (!IS_UNDEFINED(values) &&
-          %_CallFunction(values, value, ArrayIndexOf) === -1) {
+      if (!IS_UNDEFINED(values) && %_Call(ArrayIndexOf, values, value) === -1) {
         throw MakeRangeError(kValueOutOfRange, value, caller, property);
       }
 
       return value;
     }
 
     return defaultValue;
   }
 
   return getOption;
@@ skipping 28 matching lines @@
 
   return resolved;
 }
 
 
 /**
  * Returns best matched supported locale and extension info using basic
  * lookup algorithm.
  */
 function lookupMatcher(service, requestedLocales) {
-  if (IS_NULL(%_CallFunction(service, GetServiceRE(), StringMatch))) {
+  if (IS_NULL(%_Call(StringMatch, service, GetServiceRE()))) {
     throw MakeError(kWrongServiceType, service);
   }
 
   // Cache these, they don't ever change per service.
   if (IS_UNDEFINED(AVAILABLE_LOCALES[service])) {
     AVAILABLE_LOCALES[service] = getAvailableLocalesOf(service);
   }
 
   for (var i = 0; i < requestedLocales.length; ++i) {
     // Remove all extensions.
-    var locale = %_CallFunction(requestedLocales[i], GetAnyExtensionRE(), '',
-                                StringReplace);
+    var locale = %_Call(StringReplace, requestedLocales[i],
+                        GetAnyExtensionRE(), '');
     do {
       if (!IS_UNDEFINED(AVAILABLE_LOCALES[service][locale])) {
         // Return the resolved locale and extension.
         var extensionMatch =
-            %_CallFunction(requestedLocales[i], GetUnicodeExtensionRE(),
-                           StringMatch);
+            %_Call(StringMatch, requestedLocales[i], GetUnicodeExtensionRE());
         var extension = IS_NULL(extensionMatch) ? '' : extensionMatch[0];
         return {'locale': locale, 'extension': extension, 'position': i};
       }
       // Truncate locale if possible.
-      var pos = %_CallFunction(locale, '-', StringLastIndexOf);
+      var pos = %_Call(StringLastIndexOf, locale, '-');
       if (pos === -1) {
         break;
       }
-      locale = %_CallFunction(locale, 0, pos, StringSubstring);
+      locale = %_Call(StringSubstring, locale, 0, pos);
     } while (true);
   }
 
   // Didn't find a match, return default.
   if (IS_UNDEFINED(DEFAULT_ICU_LOCALE)) {
     DEFAULT_ICU_LOCALE = %GetDefaultICULocale();
   }
 
   return {'locale': DEFAULT_ICU_LOCALE, 'extension': '', 'position': -1};
 }
 
 
 /**
  * Returns best matched supported locale and extension info using
  * implementation dependend algorithm.
  */
 function bestFitMatcher(service, requestedLocales) {
   // TODO(cira): implement better best fit algorithm.
   return lookupMatcher(service, requestedLocales);
 }
 
 
 /**
  * Parses Unicode extension into key - value map.
  * Returns empty object if the extension string is invalid.
  * We are not concerned with the validity of the values at this point.
  */
 function parseExtension(extension) {
-  var extensionSplit = %_CallFunction(extension, '-', StringSplit);
+  var extensionSplit = %_Call(StringSplit, extension, '-');
 
   // Assume ['', 'u', ...] input, but don't throw.
   if (extensionSplit.length <= 2 ||
       (extensionSplit[0] !== '' && extensionSplit[1] !== 'u')) {
     return {};
   }
 
   // Key is {2}alphanum, value is {3,8}alphanum.
   // Some keys may not have explicit values (booleans).
   var extensionMap = {};
@@ skipping 116 matching lines @@
     return original;
   }
 
   var locales = %GetLanguageTagVariants([original, resolved]);
   if (locales[0].maximized !== locales[1].maximized) {
     return resolved;
   }
 
   // Preserve extensions of resolved locale, but swap base tags with original.
   var resolvedBase = new GlobalRegExp('^' + locales[1].base);
-  return %_CallFunction(resolved, resolvedBase, locales[0].base, StringReplace);
+  return %_Call(StringReplace, resolved, resolvedBase, locales[0].base);
 }
 
 
 /**
  * Returns an Object that contains all of supported locales for a given
  * service.
  * In addition to the supported locales we add xx-ZZ locale for each xx-Yyyy-ZZ
  * that is supported. This is required by the spec.
  */
 function getAvailableLocalesOf(service) {
   var available = %AvailableLocalesOf(service);
 
   for (var i in available) {
     if (%HasOwnProperty(available, i)) {
-      var parts = %_CallFunction(i, /^([a-z]{2,3})-([A-Z][a-z]{3})-([A-Z]{2})$/,
-                                 StringMatch);
+      var parts =
+          %_Call(StringMatch, i, /^([a-z]{2,3})-([A-Z][a-z]{3})-([A-Z]{2})$/);
       if (parts !== null) {
         // Build xx-ZZ. We don't care about the actual value,
         // as long it's not undefined.
         available[parts[1] + '-' + parts[3]] = null;
       }
     }
   }
 
   return available;
 }
@@ skipping 39 matching lines @@
   if (!IS_UNDEFINED(value)) {
     defineWECProperty(object, property, value);
   }
 }
 
 
 /**
  * Returns titlecased word, aMeRricA -> America.
  */
 function toTitleCaseWord(word) {
-  return %StringToUpperCase(%_CallFunction(word, 0, 1, StringSubstr)) +
-         %StringToLowerCase(%_CallFunction(word, 1, StringSubstr));
+  return %StringToUpperCase(%_Call(StringSubstr, word, 0, 1)) +
+         %StringToLowerCase(%_Call(StringSubstr, word, 1));
 }
 
 /**
  * Canonicalizes the language tag, or throws in case the tag is invalid.
  */
 function canonicalizeLanguageTag(localeID) {
   // null is typeof 'object' so we have to do extra check.
   if (typeof localeID !== 'string' && typeof localeID !== 'object' ||
       IS_NULL(localeID)) {
     throw MakeTypeError(kLanguageID);
@@ skipping 23 matching lines @@
  * Throws on locales that are not well formed BCP47 tags.
  */
 function initializeLocaleList(locales) {
   var seen = [];
   if (IS_UNDEFINED(locales)) {
     // Constructor is called without arguments.
     seen = [];
   } else {
     // We allow single string localeID.
     if (typeof locales === 'string') {
-      %_CallFunction(seen, canonicalizeLanguageTag(locales), ArrayPush);
+      %_Call(ArrayPush, seen, canonicalizeLanguageTag(locales));
       return freezeArray(seen);
     }
 
     var o = TO_OBJECT(locales);
     var len = TO_UINT32(o.length);
 
     for (var k = 0; k < len; k++) {
       if (k in o) {
         var value = o[k];
 
         var tag = canonicalizeLanguageTag(value);
 
-        if (%_CallFunction(seen, tag, ArrayIndexOf) === -1) {
-          %_CallFunction(seen, tag, ArrayPush);
+        if (%_Call(ArrayIndexOf, seen, tag) === -1) {
+          %_Call(ArrayPush, seen, tag);
         }
       }
     }
   }
 
   return freezeArray(seen);
 }
 
 
 /**
  * Validates the language tag. Section 2.2.9 of the bcp47 spec
  * defines a valid tag.
  *
  * ICU is too permissible and lets invalid tags, like
  * hant-cmn-cn, through.
  *
  * Returns false if the language tag is invalid.
  */
 function isValidLanguageTag(locale) {
   // Check if it's well-formed, including grandfadered tags.
-  if (!%_CallFunction(GetLanguageTagRE(), locale, RegExpTest)) {
+  if (!%_Call(RegExpTest, GetLanguageTagRE(), locale)) {
     return false;
   }
 
   // Just return if it's a x- form. It's all private.
-  if (%_CallFunction(locale, 'x-', StringIndexOf) === 0) {
+  if (%_Call(StringIndexOf, locale, 'x-') === 0) {
     return true;
   }
 
   // Check if there are any duplicate variants or singletons (extensions).
 
   // Remove private use section.
-  locale = %_CallFunction(locale, /-x-/, StringSplit)[0];
+  locale = %_Call(StringSplit, locale, /-x-/)[0];
 
   // Skip language since it can match variant regex, so we start from 1.
   // We are matching i-klingon here, but that's ok, since i-klingon-klingon
   // is not valid and would fail LANGUAGE_TAG_RE test.
   var variants = [];
   var extensions = [];
-  var parts = %_CallFunction(locale, /-/, StringSplit);
+  var parts = %_Call(StringSplit, locale, /-/);
   for (var i = 1; i < parts.length; i++) {
     var value = parts[i];
-    if (%_CallFunction(GetLanguageVariantRE(), value, RegExpTest) &&
+    if (%_Call(RegExpTest, GetLanguageVariantRE(), value) &&
         extensions.length === 0) {
-      if (%_CallFunction(variants, value, ArrayIndexOf) === -1) {
-        %_CallFunction(variants, value, ArrayPush);
+      if (%_Call(ArrayIndexOf, variants, value) === -1) {
+        %_Call(ArrayPush, variants, value);
       } else {
         return false;
       }
     }
 
-    if (%_CallFunction(GetLanguageSingletonRE(), value, RegExpTest)) {
-      if (%_CallFunction(extensions, value, ArrayIndexOf) === -1) {
-        %_CallFunction(extensions, value, ArrayPush);
+    if (%_Call(RegExpTest, GetLanguageSingletonRE(), value)) {
+      if (%_Call(ArrayIndexOf, extensions, value) === -1) {
+        %_Call(ArrayPush, extensions, value);
       } else {
         return false;
       }
     }
   }
 
   return true;
  }
 
 
@@ skipping 93 matching lines @@
 
     /**
      * Allowed -u-co- values. List taken from:
      * http://unicode.org/repos/cldr/trunk/common/bcp47/collation.xml
      */
     var ALLOWED_CO_VALUES = [
       'big5han', 'dict', 'direct', 'ducet', 'gb2312', 'phonebk', 'phonetic',
       'pinyin', 'reformed', 'searchjl', 'stroke', 'trad', 'unihan', 'zhuyin'
     ];
 
-    if (%_CallFunction(ALLOWED_CO_VALUES, extensionMap.co, ArrayIndexOf) !==
-        -1) {
+    if (%_Call(ArrayIndexOf, ALLOWED_CO_VALUES, extensionMap.co) !== -1) {
       extension = '-u-co-' + extensionMap.co;
       // ICU can't tell us what the collation is, so save user's input.
       collation = extensionMap.co;
     }
   } else if (internalOptions.usage === 'search') {
     extension = '-u-co-search';
   }
   defineWEProperty(internalOptions, 'collation', collation);
 
   var requestedLocale = locale.locale + extension;
@@ skipping 119 matching lines @@
 addBoundMethod(Intl.Collator, 'compare', compare, 2);
 
 /**
  * Verifies that the input is a well-formed ISO 4217 currency code.
  * Don't uppercase to test. It could convert invalid code into a valid one.
  * For example \u00DFP (Eszett+P) becomes SSP.
  */
 function isWellFormedCurrencyCode(currency) {
   return typeof currency == "string" &&
       currency.length == 3 &&
-      %_CallFunction(currency, /[^A-Za-z]/, StringMatch) == null;
+      %_Call(StringMatch, currency, /[^A-Za-z]/) == null;
 }
 
 
 /**
  * Returns the valid digit count for a property, or throws RangeError on
  * a value out of the range.
  */
 function getNumberOption(options, property, min, max, fallback) {
   var value = options[property];
   if (!IS_UNDEFINED(value)) {
@@ skipping 308 matching lines @@
     return '';
   }
 }
 
 
 /**
  * Returns object that matches LDML representation of the date.
  */
 function fromLDMLString(ldmlString) {
   // First remove '' quoted text, so we lose 'Uhr' strings.
-  ldmlString = %_CallFunction(ldmlString, GetQuotedStringRE(), '',
-                              StringReplace);
+  ldmlString = %_Call(StringReplace, ldmlString, GetQuotedStringRE(), '');
 
   var options = {};
-  var match = %_CallFunction(ldmlString, /E{3,5}/g, StringMatch);
+  var match = %_Call(StringMatch, ldmlString, /E{3,5}/g);
   options = appendToDateTimeObject(
       options, 'weekday', match, {EEEEE: 'narrow', EEE: 'short', EEEE: 'long'});
 
-  match = %_CallFunction(ldmlString, /G{3,5}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /G{3,5}/g);
   options = appendToDateTimeObject(
       options, 'era', match, {GGGGG: 'narrow', GGG: 'short', GGGG: 'long'});
 
-  match = %_CallFunction(ldmlString, /y{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /y{1,2}/g);
   options = appendToDateTimeObject(
       options, 'year', match, {y: 'numeric', yy: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /M{1,5}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /M{1,5}/g);
   options = appendToDateTimeObject(options, 'month', match, {MM: '2-digit',
       M: 'numeric', MMMMM: 'narrow', MMM: 'short', MMMM: 'long'});
 
   // Sometimes we get L instead of M for month - standalone name.
-  match = %_CallFunction(ldmlString, /L{1,5}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /L{1,5}/g);
   options = appendToDateTimeObject(options, 'month', match, {LL: '2-digit',
       L: 'numeric', LLLLL: 'narrow', LLL: 'short', LLLL: 'long'});
 
-  match = %_CallFunction(ldmlString, /d{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /d{1,2}/g);
   options = appendToDateTimeObject(
       options, 'day', match, {d: 'numeric', dd: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /h{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /h{1,2}/g);
   if (match !== null) {
     options['hour12'] = true;
   }
   options = appendToDateTimeObject(
       options, 'hour', match, {h: 'numeric', hh: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /H{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /H{1,2}/g);
   if (match !== null) {
     options['hour12'] = false;
   }
   options = appendToDateTimeObject(
       options, 'hour', match, {H: 'numeric', HH: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /m{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /m{1,2}/g);
   options = appendToDateTimeObject(
       options, 'minute', match, {m: 'numeric', mm: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /s{1,2}/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /s{1,2}/g);
   options = appendToDateTimeObject(
       options, 'second', match, {s: 'numeric', ss: '2-digit'});
 
-  match = %_CallFunction(ldmlString, /z|zzzz/g, StringMatch);
+  match = %_Call(StringMatch, ldmlString, /z|zzzz/g);
   options = appendToDateTimeObject(
       options, 'timeZoneName', match, {z: 'short', zzzz: 'long'});
 
   return options;
 }
 
 
 function appendToDateTimeObject(options, option, match, pairs) {
   if (IS_NULL(match)) {
     if (!%HasOwnProperty(options, option)) {
@@ skipping 312 matching lines @@
 
   // Special case handling (UTC, GMT).
   var upperID = %StringToUpperCase(tzID);
   if (upperID === 'UTC' || upperID === 'GMT' ||
       upperID === 'ETC/UTC' || upperID === 'ETC/GMT') {
     return 'UTC';
   }
 
   // We expect only _ and / beside ASCII letters.
   // All inputs should conform to Area/Location from now on.
-  var match = %_CallFunction(tzID, GetTimezoneNameCheckRE(), StringMatch);
+  var match = %_Call(StringMatch, tzID, GetTimezoneNameCheckRE());
   if (IS_NULL(match)) throw MakeRangeError(kExpectedLocation, tzID);
 
   var result = toTitleCaseWord(match[1]) + '/' + toTitleCaseWord(match[2]);
   var i = 3;
   while (!IS_UNDEFINED(match[i]) && i < match.length) {
     result = result + '_' + toTitleCaseWord(match[i]);
     i++;
   }
 
   return result;
@@ skipping 241 matching lines @@
     }
 
     CHECK_OBJECT_COERCIBLE(this, "String.prototype.normalize");
     var s = TO_STRING(this);
 
     var formArg = %_Arguments(0);
     var form = IS_UNDEFINED(formArg) ? 'NFC' : TO_STRING(formArg);
 
     var NORMALIZATION_FORMS = ['NFC', 'NFD', 'NFKC', 'NFKD'];
 
-    var normalizationForm =
-        %_CallFunction(NORMALIZATION_FORMS, form, ArrayIndexOf);
+    var normalizationForm = %_Call(ArrayIndexOf, NORMALIZATION_FORMS, form);
     if (normalizationForm === -1) {
       throw MakeRangeError(kNormalizationForm,
-          %_CallFunction(NORMALIZATION_FORMS, ', ', ArrayJoin));
+          %_Call(ArrayJoin, NORMALIZATION_FORMS, ', '));
     }
 
     return %StringNormalize(s, normalizationForm);
   }
 );
 
 
 /**
  * Formats a Number object (this) using locale and options values.
  * If locale or options are omitted, defaults are used.
@@ skipping 81 matching lines @@
     }
 
     var locales = %_Arguments(0);
     var options = %_Arguments(1);
     return toLocaleDateTime(
         this, locales, options, 'time', 'time', 'dateformattime');
   }
 );
 
 })