Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/debug/debug.js

Issue 1419813010: [runtime] Remove the very dangerous %_CallFunction intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/debug/mirrors.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function (global, utils) { 5 (function (global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
(...skipping 1401 matching lines...) Expand 10 before | Expand all | Expand 10 after
1412 response.setOption('inlineRefs', true); 1412 response.setOption('inlineRefs', true);
1413 } 1413 }
1414 if (!IS_UNDEFINED(args.maxStringLength)) { 1414 if (!IS_UNDEFINED(args.maxStringLength)) {
1415 response.setOption('maxStringLength', args.maxStringLength); 1415 response.setOption('maxStringLength', args.maxStringLength);
1416 } 1416 }
1417 } 1417 }
1418 1418
1419 var key = request.command.toLowerCase(); 1419 var key = request.command.toLowerCase();
1420 var handler = DebugCommandProcessor.prototype.dispatch_[key]; 1420 var handler = DebugCommandProcessor.prototype.dispatch_[key];
1421 if (IS_FUNCTION(handler)) { 1421 if (IS_FUNCTION(handler)) {
1422 %_CallFunction(this, request, response, handler); 1422 %_Call(handler, this, request, response);
1423 } else { 1423 } else {
1424 throw MakeError(kDebugger, 1424 throw MakeError(kDebugger,
1425 'Unknown command "' + request.command + '" in request'); 1425 'Unknown command "' + request.command + '" in request');
1426 } 1426 }
1427 } catch (e) { 1427 } catch (e) {
1428 // If there is no response object created one (without command). 1428 // If there is no response object created one (without command).
1429 if (!response) { 1429 if (!response) {
1430 response = this.createResponse(); 1430 response = this.createResponse();
1431 } 1431 }
1432 response.success = false; 1432 response.success = false;
(...skipping 1185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2618 "IsBreakPointTriggered", IsBreakPointTriggered, 2618 "IsBreakPointTriggered", IsBreakPointTriggered,
2619 "UpdateScriptBreakPoints", UpdateScriptBreakPoints, 2619 "UpdateScriptBreakPoints", UpdateScriptBreakPoints,
2620 ]); 2620 ]);
2621 2621
2622 // Export to liveedit.js 2622 // Export to liveedit.js
2623 utils.Export(function(to) { 2623 utils.Export(function(to) {
2624 to.GetScriptBreakPoints = GetScriptBreakPoints; 2624 to.GetScriptBreakPoints = GetScriptBreakPoints;
2625 }); 2625 });
2626 2626
2627 }) 2627 })
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/debug/mirrors.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698