Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1419813006: Fixing broken nacl toolchain references. (Closed)

Created:
5 years, 1 month ago by Sean Klein
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Undo rebasepath #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M DEPS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sean Klein
5 years, 1 month ago (2015-10-29 22:40:09 UTC) #2
jamesr
lgtm https://codereview.chromium.org/1419813006/diff/1/mojo/nacl/nonsfi/BUILD.gn File mojo/nacl/nonsfi/BUILD.gn (right): https://codereview.chromium.org/1419813006/diff/1/mojo/nacl/nonsfi/BUILD.gn#newcode89 mojo/nacl/nonsfi/BUILD.gn:89: "//native_client/toolchain/${nacl_toolchain_host_os}_x86/pnacl_newlib/bin/pydir/loader.py") please do this change separately (there's a ...
5 years, 1 month ago (2015-10-29 22:43:00 UTC) #3
Sean Klein
5 years, 1 month ago (2015-10-29 22:46:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6cb161d45836eafe060f6e6e9ab75501349acfb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698