Issue 1419813006: Fixing broken nacl toolchain references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1419813006: Fixing broken nacl toolchain references. (Closed)

Created:
5 years, 1 month ago by Sean Klein

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fixing broken nacl toolchain references. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f6cb161d45836eafe060f6e6e9ab75501349acfb

Patch Set 2 : Undo rebasepath #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm https://codereview.chromium.org/1419813006/diff/1/mojo/nacl/nonsfi/BUILD.gn File mojo/nacl/nonsfi/BUILD.gn (right): https://codereview.chromium.org/1419813006/diff/1/mojo/nacl/nonsfi/BUILD.gn#newcode89 mojo/nacl/nonsfi/BUILD.gn:89: "//native_client/toolchain/${nacl_toolchain_host_os}_x86/pnacl_newlib/bin/pydir/loader.py") please do this change separately (there's a ...

5 years, 1 month ago (2015-10-29 22:43:00 UTC) #3

Sean Klein

5 years, 1 month ago (2015-10-29 22:46:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f6cb161d45836eafe060f6e6e9ab75501349acfb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1419813006: Fixing broken nacl toolchain references. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Undo rebasepath #

Messages