Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1419813005: DevTools: always use CodeMirror for response preview (Closed)

Created:
5 years, 1 month ago by lushnikov
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: always use CodeMirror for response preview Currently, the response preview of Network Panel uses CodeMirror for contents less then ~100Kb and fallbacks to a simple DIV with word-wrapped text otherwise. The DIV with word-wrapped text might be very slow to render. The fallback was implemented in crrev.com/14432002 to avoid text truncation bug in codeMirror: crbug.com/168052. Nowadays, the bug does not seem to be reproducible in CodeMirror any more, so it is safe to use CodeMirror all the time. BUG=519131 R=pfeldman Committed: https://crrev.com/bcbae5e5ff246b578c4cd03bb8ded107a60cd3db Cr-Commit-Position: refs/heads/master@{#356981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/ResourceSourceFrame.js View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/module.json View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/source_frame/resourceSourceFrame.css View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lushnikov
ptal
5 years, 1 month ago (2015-10-29 20:52:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813005/1
5 years, 1 month ago (2015-10-29 20:54:10 UTC) #3
pfeldman
lgtm
5 years, 1 month ago (2015-10-29 22:31:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 23:02:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419813005/1
5 years, 1 month ago (2015-10-29 23:07:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 23:31:13 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 23:32:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcbae5e5ff246b578c4cd03bb8ded107a60cd3db
Cr-Commit-Position: refs/heads/master@{#356981}

Powered by Google App Engine
This is Rietveld 408576698