third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/flipped-blocks-hit-test.html ('k') | third_party/WebKit/LayoutTests/fast/multicol/newmulticol/hide-box-horizontal-bt.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html b/third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

index 0f34db6f80615c12ba682867334a157f470c78b4..aaec74f5a997de73e440ebf3635bba39697948f7 100644

--- a/third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

+++ b/third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

@@ -6,8 +6,8 @@

columns: 2;

column-gap: 0;

column-fill: auto;

- width: 400px;

- height: 80px;

+ -webkit-logical-width: 400px;

+ -webkit-logical-height: 80px;

font: 20px Ahem;

line-height: 2;

">Lorem ipsum dolor sit amet</div>

@@ -32,14 +32,14 @@

log(hitOffset === 14 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");

// Now test with a flipped lines writing mode.

- target.style.webkitWritingMode = "horizontal-bt";

+ target.style.webkitWritingMode = "vertical-rl";

// Clicking above the last line in the first column should not select anything from the first

// line on the second column.

- hitOffset = document.caretRangeFromPoint(target.offsetLeft + 190, target.offsetTop + 3).startOffset;

+ hitOffset = document.caretRangeFromPoint(target.offsetLeft + 80, target.offsetTop + 193).startOffset;

log(hitOffset === 11 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");

// Clicking below the first line in the second column should not snap to the beginning of the line.

- hitOffset = document.caretRangeFromPoint(target.offsetLeft + 250, target.offsetTop + 78).startOffset;

+ hitOffset = document.caretRangeFromPoint(target.offsetLeft + 77, target.offsetTop + 250).startOffset;

log(hitOffset === 14 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");

</script>