Scrolls to the notification when focus moves to its buttons.

Scrolls to the notification when focus moves to its buttons.

BUG=224974
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194699

[dewittj, 2013-04-13 00:15:23]

If I understand this correctly, this will only scroll until the button that's
focused is visible.  Do we want to scroll until the whole notification is
visible?

[Jun Mukai, 2013-04-13 00:25:10]

On 2013/04/13 00:15:23, dewittj wrote:
> If I understand this correctly, this will only scroll until the button that's
> focused is visible.  Do we want to scroll until the whole notification is
> visible?

NotificationView::ScrollRectToVisible does that actually ;-)

When a view calls ScrollRectToVisible, it computes the region and calls parent's
ScrollRectToVisible, and parent and parent... and finally it reaches to the
ScrollView which is responsible for scrolling.

When a button is focused, its NotificationView has to be in this parent chain,
and it calls ScrollRectToVisible with its own LocalBounds instead of bounds in
the arguments, therefore it will scroll to show the whole notification.

[dharcourt, 2013-04-13 07:49:42]

lgtm

[dewittj, 2013-04-15 18:40:51]

lgtm

Thanks for the explanation.

[Jun Mukai, 2013-04-17 21:56:16]

Committed patchset #1 manually as r194699 (presubmit successful).