Setup and tear down V8 if the PDF module is not managed via pepper

Setup and tear down V8 if the PDF module is not managed via pepper

BUG=549365
R=thestig@chromium.org

Committed: https://crrev.com/260ecd51b9f2090da212f3920f25809b945dd7d3
Cr-Commit-Position: refs/heads/master@{#358269}

[Lei Zhang, 2015-11-05 21:40:37]

Description was changed from

==========
Setup and tearn down V8 if the PDF module is not managed via pepper

BUG=549365
R=thestig@chromium.org
==========

to

==========
Setup and tear down V8 if the PDF module is not managed via pepper

BUG=549365
R=thestig@chromium.org
==========

[Lei Zhang, 2015-11-05 21:44:01]

Thanks. I corrected the typo in the CL description.

https://codereview.chromium.org/1419793008/diff/1/pdf/pdf.cc
File pdf/pdf.cc (right):

https://codereview.chromium.org/1419793008/diff/1/pdf/pdf.cc#newcode72
pdf/pdf.cc:72: if (!chrome_pdf::InitializeSDK()) {
Should we write wrappers for chrome_pdf::InitializeSDK() and
chrome_pdf::ShutdownSDK() instead? It seems we call SetUpV8() and TearDownV8()
in all the same places.

[jochen (gone - plz use gerrit), 2015-11-06 04:44:16]

ptal

[Lei Zhang, 2015-11-06 05:04:12]

lgtm

https://codereview.chromium.org/1419793008/diff/20001/pdf/pdfium/pdfium_engin...
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1419793008/diff/20001/pdf/pdfium/pdfium_engin...
pdf/pdfium/pdfium_engine.cc:489: return true;
And we don't even return false. I'll fix this by checking the FPDF_ calls to
make sure they actually succeed.

[jochen (gone - plz use gerrit), 2015-11-06 05:09:46]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-11-06 05:10:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419793008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419793008/20001

[commit-bot: I haz the power, 2015-11-06 05:57:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-06 05:58:03]

Patchset 2 (id:??) landed as
https://crrev.com/260ecd51b9f2090da212f3920f25809b945dd7d3
Cr-Commit-Position: refs/heads/master@{#358269}