Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1419793007: X87: [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. port ab84025977fb94bebf7d4d83b874da5a6c1c6293 (r31790). original commit message: The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. BUG= Committed: https://crrev.com/8c1a4330380e973d0107b5fa24fa1d094faeb91f Cr-Commit-Position: refs/heads/master@{#31815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-05 02:34:15 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-05 04:54:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419793007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419793007/1
5 years, 1 month ago (2015-11-05 04:54:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 05:11:50 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 05:12:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c1a4330380e973d0107b5fa24fa1d094faeb91f
Cr-Commit-Position: refs/heads/master@{#31815}

Powered by Google App Engine
This is Rietveld 408576698