Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: components/mus/ws/window_manager_client_apptest.cc

Issue 1419793006: Makes windowmanager draw non-client area (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move wm nonclientframeview to wm Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/ws/window_manager_client_apptest.cc
diff --git a/components/mus/ws/window_manager_client_apptest.cc b/components/mus/ws/window_manager_client_apptest.cc
index 23c57933c96ecf89cab140ea28c482a67db7d96f..f09e644c75601f57d5026f21cd9bcfbd85f4ae1f 100644
--- a/components/mus/ws/window_manager_client_apptest.cc
+++ b/components/mus/ws/window_manager_client_apptest.cc
@@ -61,7 +61,7 @@ class ClientAreaChangeObserver : public WindowObserver {
private:
// Overridden from WindowObserver:
void OnWindowClientAreaChanged(Window* window,
- const gfx::Rect& old_client_area) override {
+ const gfx::Insets& old_client_area) override {
DCHECK_EQ(window, window_);
EXPECT_TRUE(WindowServerTestBase::QuitRunLoop());
}
@@ -874,16 +874,16 @@ TEST_F(WindowServerTest, ClientAreaChanged) {
WindowTreeConnection* embedded_connection = Embed(embed_window).connection;
// Verify change from embedded makes it to parent.
- embedded_connection->GetRoot()->SetClientArea(gfx::Rect(1, 2, 3, 4));
+ embedded_connection->GetRoot()->SetClientArea(gfx::Insets(1, 2, 3, 4));
ASSERT_TRUE(WaitForClientAreaToChange(embed_window));
- EXPECT_TRUE(gfx::Rect(1, 2, 3, 4) == embed_window->client_area());
+ EXPECT_TRUE(gfx::Insets(1, 2, 3, 4) == embed_window->client_area());
- // Verify bounds change results in resetting client area in embedded.
+ // Changing bounds shouldn't effect client area.
embed_window->SetBounds(gfx::Rect(21, 22, 23, 24));
WaitForBoundsToChange(embedded_connection->GetRoot());
EXPECT_TRUE(gfx::Rect(21, 22, 23, 24) ==
embedded_connection->GetRoot()->bounds());
- EXPECT_TRUE(gfx::Rect(0, 0, 23, 24) ==
+ EXPECT_TRUE(gfx::Insets(1, 2, 3, 4) ==
embedded_connection->GetRoot()->client_area());
}

Powered by Google App Engine
This is Rietveld 408576698