Makes windowmanager draw non-client area

Makes windowmanager draw non-client area

The high level bits are the following:
. Client area is now expressed as insets. This avoids resetting the
  client area any time the bounds changes.
. WindowManager now exposes preferred insets.
. Client side creates a NonClientFrameView that reflects insets
  exposed from WM.
. WM's NonClientFrameView (which draws underneat the client's surface)
  draws the frame decorations. It fills in the client area as black.

BUG=548420
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/56961cd296980da6de2b537d65a104da24af2b60
Cr-Commit-Position: refs/heads/master@{#357995}

[Ben Goodger (Google), 2015-11-04 23:03:21]

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/non_client_frame_controller.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_controller.cc:14: class
WmNativeWidgetMus : public views::NativeWidgetMus {
I don't think you need to subclass here. Instead this can be a bare widget. Is
there a reason you need to use the NonClientFrameView infra? That mostly only
exists for dealing with non-client and client areas within one process.

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/non_client_frame_view_impl.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_view_impl.cc:32: LOG(WARNING) <<
"OnPaint " << window_->client_area().top();
nit: remove

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_view_impl.cc:53: LOG(WARNING) <<
"OnWindowClientAreaChanged " << window_->client_area().top();
etc

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/window_manager_application.h (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/window_manager_application.h:78:
scoped_ptr<views::AuraInit> aura_init_;
you'll have to merge my other change.

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:110: void UpdateWindowIcon() override {
NOTIMPLEMENTED(); }
// NOTIMPLEMENTED()

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/window_man...
File ui/views/mus/window_manager_connection.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/window_man...
ui/views/mus/window_manager_connection.cc:86:
NativeWidgetMus::SetWindowManagerClientAreaInsets(client_insets);
i'm a little concerned about this API in the future for when the window manager
restarts.

[sky, 2015-11-05 00:18:02]

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/non_client_frame_controller.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_controller.cc:14: class
WmNativeWidgetMus : public views::NativeWidgetMus {
On 2015/11/04 23:03:21, Ben Goodger (Google) wrote:
> I don't think you need to subclass here. Instead this can be a bare widget. Is
> there a reason you need to use the NonClientFrameView infra? That mostly only
> exists for dealing with non-client and client areas within one process.

CustomFrameView and related classes assume they are the nonclientview. To do
otherwise gives random crashes. For example,
NonClientFrameView::DoesIntersectRect() has
GetWidget()->client_view() . Seems best to use the existing infrastructure.

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/non_client_frame_view_impl.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_view_impl.cc:32: LOG(WARNING) <<
"OnPaint " << window_->client_area().top();
On 2015/11/04 23:03:21, Ben Goodger (Google) wrote:
> nit: remove

Done.

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/non_client_frame_view_impl.cc:53: LOG(WARNING) <<
"OnWindowClientAreaChanged " << window_->client_area().top();
On 2015/11/04 23:03:21, Ben Goodger (Google) wrote:
> etc

Done.

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
File components/mus/example/wm/window_manager_application.h (right):

https://codereview.chromium.org/1419793006/diff/20001/components/mus/example/...
components/mus/example/wm/window_manager_application.h:78:
scoped_ptr<views::AuraInit> aura_init_;
On 2015/11/04 23:03:21, Ben Goodger (Google) wrote:
> you'll have to merge my other change.

Done.

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1419793006/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:110: void UpdateWindowIcon() override {
NOTIMPLEMENTED(); }
On 2015/11/04 23:03:21, Ben Goodger (Google) wrote:
> // NOTIMPLEMENTED()

Done.

[Ben Goodger (Google), 2015-11-05 00:41:27]

ok, lgtm

[sky, 2015-11-05 01:39:33]

The CQ bit was checked by sky@chromium.org

[sky, 2015-11-05 01:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1419793006/#ps60001
(title: "add include")

[commit-bot: I haz the power, 2015-11-05 01:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419793006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419793006/60001

[commit-bot: I haz the power, 2015-11-05 03:47:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-05 03:48:58]

Patchset 4 (id:??) landed as
https://crrev.com/56961cd296980da6de2b537d65a104da24af2b60
Cr-Commit-Position: refs/heads/master@{#357995}