Check fread() return values in CFX_FolderFontInfo::GetFontData().

Check fread() return values in CFX_FolderFontInfo::GetFontData().

Check fseek() return values too.

BUG=549998
R=thakis@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/99818557c8ed64d00fcc23a1e87e1ebf41ed5e85

[Lei Zhang, 2015-11-02 19:36:27]

thestig@chromium.org changed reviewers:
+ thakis@chromium.org

[Lei Zhang, 2015-11-02 19:36:27]

This function needs work, but this is the minimum to get us rolling again.

[Nico, 2015-11-02 19:55:44]

lgtm I suppose.

https://codereview.chromium.org/1419793003/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1419793003/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:1512: if (datasize && size >= datasize &&
pFile) {
From how I understood the code, this check was supposed to make sure this would
never happen (no idea if it did so successfully)…

[Lei Zhang, 2015-11-02 19:59:09]

https://codereview.chromium.org/1419793003/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1419793003/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:1512: if (datasize && size >= datasize &&
pFile) {
On 2015/11/02 19:55:43, Nico wrote:
> From how I understood the code, this check was supposed to make sure this
would
> never happen (no idea if it did so successfully)…

Just because the buffer is big enough, and |pFile| is not NULL, that does not
mean fread() is guaranteed to succeed. e.g. the OS can have a bad day and say
"no data for you!"

[Lei Zhang, 2015-11-02 21:29:30]

Committed patchset #1 (id:1) manually as
99818557c8ed64d00fcc23a1e87e1ebf41ed5e85 (presubmit successful).