Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/compiler/machine-operator.h

Issue 1419753008: MIPS: [turbofan] Properly implement Float64/32 Min/Max instructions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add TF FloatMin|Max execution tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/machine-operator.h
diff --git a/src/compiler/machine-operator.h b/src/compiler/machine-operator.h
index 2a80feecded6f01574f7c156228af6e41573c115..11f62b2e4b736c1e4f4c303a769200fa28f7fc03 100644
--- a/src/compiler/machine-operator.h
+++ b/src/compiler/machine-operator.h
@@ -236,10 +236,14 @@ class MachineOperatorBuilder final : public ZoneObject {
// Floating point min/max complying to IEEE 754 (single-precision).
const OptionalOperator Float32Max();
const OptionalOperator Float32Min();
+ bool HasFloat32Max() const { return flags_ & kFloat32Max; }
Benedikt Meurer 2015/11/03 05:39:00 You don't need these functions. Just use Float32Ma
dusan.milosavljevic 2015/11/03 13:48:34 Done.
dusan.milosavljevic 2015/11/03 13:48:34 Right, exactly what I need. Thank you.
+ bool HasFloat64Max() const { return flags_ & kFloat64Max; }
Benedikt Meurer 2015/11/03 05:39:00 Same as above.
// Floating point min/max complying to IEEE 754 (double-precision).
const OptionalOperator Float64Max();
const OptionalOperator Float64Min();
+ bool HasFloat32Min() const { return flags_ & kFloat32Min; }
Benedikt Meurer 2015/11/03 05:39:00 Same as above.
dusan.milosavljevic 2015/11/03 13:48:34 Done.
+ bool HasFloat64Min() const { return flags_ & kFloat64Min; }
// Floating point abs complying to IEEE 754 (single-precision).
const Operator* Float32Abs();
« no previous file with comments | « no previous file | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698