MIPS: [turbofan] Properly implement Float64/32 Min/Max instructions.

src/compiler/mips64/code-generator-mips64.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/osr.h"
 #include "src/mips/macro-assembler-mips.h"
@@ skipping 768 matching lines @@
       break;
     }
     case kMips64Float64RoundTruncate: {
       ASSEMBLE_ROUND_DOUBLE_TO_DOUBLE(trunc_l_d, Truncate);
       break;
     }
     case kMips64Float64RoundUp: {
       ASSEMBLE_ROUND_DOUBLE_TO_DOUBLE(ceil_l_d, Ceil);
       break;
     }
+    case kMips64Float64Max: {
+      // (b < a) ? a : b
+      if (kArchVariant == kMips64r6) {

[paul.l..., 2015/11/02 22:35:12]

Please see comments in mips32 version, they all apply here.

+        __ cmp(OLT, L, kScratchDoubleReg, i.InputDoubleRegister(0),
+               i.InputDoubleRegister(1));
+        __ sel_d(i.OutputSingleRegister(), i.InputDoubleRegister(1),
+                 kScratchDoubleReg);
+      } else {
+        __ c(OLT, D, i.InputDoubleRegister(0), i.InputDoubleRegister(1));
+        // Left operand is result, passthrough if false.
+        __ movt_d(i.OutputSingleRegister(), i.InputDoubleRegister(1));
+      }
+      break;
+    }
+    case kMips64Float64Min: {
+      // (a < b) ? a : b
+      if (kArchVariant == kMips64r6) {
+        __ cmp(OLT, L, kScratchDoubleReg, i.InputDoubleRegister(0),
+               i.InputDoubleRegister(1));
+        __ sel_d(i.OutputSingleRegister(), i.InputDoubleRegister(1),
+                 kScratchDoubleReg);
+      } else {
+        __ c(OLT, D, i.InputDoubleRegister(1), i.InputDoubleRegister(0));
+        // Right operand is result, passthrough if false.
+        __ movt_d(i.OutputSingleRegister(), i.InputDoubleRegister(1));
+      }
+      break;
+    }
+    case kMips64Float32Max: {
+      // (b < a) ? a : b
+      if (kArchVariant == kMips64r6) {
+        __ cmp(OLT, W, kScratchDoubleReg, i.InputDoubleRegister(0),
+               i.InputDoubleRegister(1));
+        __ sel_s(i.OutputSingleRegister(), i.InputDoubleRegister(1),
+                 kScratchDoubleReg);
+      } else {
+        __ c(OLT, S, i.InputDoubleRegister(0), i.InputDoubleRegister(1));
+        // Left operand is result, passthrough if false.
+        __ movt_s(i.OutputSingleRegister(), i.InputDoubleRegister(1));
+      }
+      break;
+    }
+    case kMips64Float32Min: {
+      // (a < b) ? a : b
+      if (kArchVariant == kMips64r6) {
+        __ cmp(OLT, W, kScratchDoubleReg, i.InputDoubleRegister(0),
+               i.InputDoubleRegister(1));
+        __ sel_d(i.OutputSingleRegister(), i.InputDoubleRegister(1),
+                 kScratchDoubleReg);
+      } else {
+        __ c(OLT, S, i.InputDoubleRegister(1), i.InputDoubleRegister(0));
+        // Right operand is result, passthrough if false.
+        __ movt_s(i.OutputSingleRegister(), i.InputDoubleRegister(1));
+      }
+      break;
+    }
     case kMips64CvtSD:
       __ cvt_s_d(i.OutputSingleRegister(), i.InputDoubleRegister(0));
       break;
     case kMips64CvtDS:
       __ cvt_d_s(i.OutputDoubleRegister(), i.InputSingleRegister(0));
       break;
     case kMips64CvtDW: {
       FPURegister scratch = kScratchDoubleReg;
       __ mtc1(i.InputRegister(0), scratch);
       __ cvt_d_w(i.OutputDoubleRegister(), scratch);
@@ skipping 743 matching lines @@
       padding_size -= v8::internal::Assembler::kInstrSize;
     }
   }
 }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8